Last Comment Bug 497242 - [FIX]getElementsByName should not find non-HTML nodes
: [FIX]getElementsByName should not find non-HTML nodes
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Boris Zbarsky [:bz]
Depends on:
  Show dependency treegraph
Reported: 2009-06-09 17:17 PDT by Boris Zbarsky [:bz]
Modified: 2009-06-19 13:58 PDT (History)
3 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix (3.36 KB, patch)
2009-06-09 17:31 PDT, Boris Zbarsky [:bz]
jonas: review+
jonas: superreview+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2009-06-09 17:17:06 PDT
This was brought up on public-html, and I think it makes a lot of sense to do, no matter what else is decided about getElementsByName.
Comment 1 Boris Zbarsky [:bz] 2009-06-09 17:31:23 PDT
Created attachment 382415 [details] [diff] [review]
Comment 2 Jonas Sicking (:sicking) No longer reading bugmail consistently 2009-06-19 12:33:54 PDT
Comment on attachment 382415 [details] [diff] [review]

>+  return
>+    aContent->IsNodeOfType(nsINode::eHTML) &&

aContent->GetNameSpaceID() == kNameSpaceID_XHTML

r/sr=me with that
Comment 3 Boris Zbarsky [:bz] 2009-06-19 13:58:24 PDT
Pushed with that change.

Note You need to log in before you can comment on or make changes to this bug.