Closed
Bug 497242
Opened 16 years ago
Closed 16 years ago
[FIX]getElementsByName should not find non-HTML nodes
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
3.36 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
This was brought up on public-html, and I think it makes a lot of sense to do, no matter what else is decided about getElementsByName.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #382415 -
Flags: superreview?(jonas)
Attachment #382415 -
Flags: review?(jonas)
Comment on attachment 382415 [details] [diff] [review]
Fix
>+ return
>+ aContent->IsNodeOfType(nsINode::eHTML) &&
aContent->GetNameSpaceID() == kNameSpaceID_XHTML
r/sr=me with that
Attachment #382415 -
Flags: superreview?(jonas)
Attachment #382415 -
Flags: superreview+
Attachment #382415 -
Flags: review?(jonas)
Attachment #382415 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/3d418e08a8e0 with that change.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•