497459 - Make screencast preview not insert {SCREENCAST} snippet

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[David Tenser [:djst]]

Attachment: Mockup UI

So, the current situation is this:

* Inserting .flv screencasts require you to click on the edge of the thumbnail. If you click on the actual screencast object, it will just start to play.
* Inserting .ogg screencasts can be done by clicking anywhere on the video object, but that will also trigger a "play video" event (or if you click on the Pause button, a Pause event)

Let's change this to the following:

* Make the thumbnails/previews of the video just previews and don't trigger the inserting of the {SCREENCAST} code when interacting with them.
* Add a small "Insert Screencast" link below each preview.

For .swf files, there is no way to preview. For these, we will simply keep the current preview placeholder. 

We might want to add an overlay text saying "Preview not possible" though, to be less confusing.

Comment 1

[David Tenser [:djst]]

To clarify, attachment 382598 [details] shows, from left to right: .ogg, .swf, .flv

So, the one in the middle is the sfw that doesn't support preview.

Comment 2

[E. Cooper [:ecooper]]

Patch will be up for review shortly.

Comment 3

[E. Cooper [:ecooper]]

Attachment: v1

This changes the thumbnails to render with the requested behavior. I'll post a screenshot in a moment.

This *does* not implement the 'Preview not possible' overlay for SWF thumbnails. I didn't do this for two reasons.
* We don't have an easily managed way to get tiki translations from javascript yet. The current way is cumbersome and hacky (which is using inline js within a smarty template). Adding more and more strings is just going to make this more and more unmaintainable.
* So far, the only SWF files with Stage.scaleMode set to noScale are the Jing screencasts. Other SWF files that allow scaling can be shown as previews without clipping issues. (not so much of a reason as something I just wanted to mention).

I do think it's a necessary idea, though. So, how do you feel about adding 'Preview not possible' directly to the placeholder? The caveat would be that it wouldn't be translatable, but it's an easy and simple solution until a sustainable way to get translations through JS is developed (which is going to become more and more relevant as we move more and more stuff to client-side checking and javascript).

Comment 4

[E. Cooper [:ecooper]]

Attachment: Screenshot of new behavior in 3.0.10 in Ubuntu

That should be "*does not*", not just "*does* not." I'm going to just blame the 3 hours of sleep on that.

First file is FLV, second is SWF.

Comment 5

[E. Cooper [:ecooper]]

r27580/r27581

I'll leave this open momentarily until part two of comment 3 is commented on.

Comment 6

[E. Cooper [:ecooper]]

Attachment: v1.1

David requested we do the text overlay, so here it is. Screenshot and darkened play button placeholder coming up shortly.

Comment 7

[E. Cooper [:ecooper]]

r27596/r27597

This also includes the darkened play button placeholder image, which I'll
attach to the bug for reference.

Comment 8

[E. Cooper [:ecooper]]

Attachment: New placeholder image

Comment 9

[David Tenser [:djst]]

Looks lovely! Let's ship this thing. :)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

I think this can safely be resolved as fixed, now, right?

Comment 11

[E. Cooper [:ecooper]]

Yeah, I think so. I'm in a dayquil stupor, but I'm pretty sure this is all set.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- this was well-tested before we shipped.