Closed Bug 497598 Opened 12 years ago Closed 12 years ago

hang on shutdown appending msg to imap folder via a filter

Categories

(MailNews Core :: Networking: IMAP, defect)

x86
Windows Vista
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0rc1

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Keywords: hang)

Attachments

(2 files)

Attached patch proposed fixSplinter Review
I have a filter that copies incoming pop3 mail to an imap folder - if I shutdown at the wrong time, it hangs because the underlying temp file that's getting appended gets removed, and we spin reading 0 bytes from the file input stream.

The underlying file shouldn't be getting removed (rkent is working on fixing that, I think), but we shouldn't be getting 0 bytes back from the file inputstream either, and I think bailing out here is better than spinning.
Attachment #382730 - Flags: superreview?(bugzilla)
Attachment #382730 - Flags: review?(bugzilla)
this hits me often enough that it's worth trying to fix.
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b4
Attachment #382730 - Flags: superreview?(bugzilla)
Attachment #382730 - Flags: superreview+
Attachment #382730 - Flags: review?(bugzilla)
Attachment #382730 - Flags: review+
fix checked in.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.0b3
This needs a different fix - Wayne is having this problem in the real world, and I've got a different possible fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0rc1
Attached patch different fixSplinter Review
we should be checking for the zero length file before we start issuing protocol.
I've requested a try server build with the above patch so Wayne can see if it fixes his problem.
try build got me through my problem
Attachment #405938 - Flags: superreview?(neil)
Attachment #405938 - Flags: review?(neil)
Attachment #405938 - Flags: superreview?(neil)
Attachment #405938 - Flags: superreview+
Attachment #405938 - Flags: review?(neil)
Attachment #405938 - Flags: review+
second patch checked in.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Severity: normal → critical
Status: RESOLVED → VERIFIED
Keywords: hang
You need to log in before you can comment on or make changes to this bug.