497663 - Insert reminder note into embed-replacements locale files with strings.in counterparts

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We have an embed-replacements file (crashes.properties) that is basically forked into global_locale_crashes_properties.strings.in for l10n purposes, and another, typeaheadfind.properties, that also has a .strings.in equivalent (though the latter is never called by the Gecko stringBundleOverride service, alas).

It would be useful, particularly for crashes.properties, if the embed-replacements versions contained some sort of comment reminding us to port (or make) any changes we may ever want to make to the .strings.in versions instead.

As an alterative, we could verify that about:crashes worked properly with crashes.properties removed from the jar and then remove crashes.properties from embed-replacements.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Removes crashes.properties and adds a note to the typeaheadfind files

This takes the second option, on the theory that fewer files are better; I removed crashes.properties from embed.jar and ran in both English and pseudo-French and about:crashes still worked correctly.

Comment 2

[Stuart Morgan]

Comment on attachment 383576 [details] [diff] [review]
Removes crashes.properties and adds a note to the typeaheadfind files

sr=smorgan

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in, with, uh, the correct comment syntax for the .strings(.in) file.  Oops ;)