497797 - drag and drop local file is not enabled

Status: RESOLVED DUPLICATE of bug 338478

(Core :: Widget: Win32, defect)

Description

[Phil Lacy]

kfilemime (x-mox-file) transferable flavor does not have code to deal with drag and drop.

Comment 1

[Phil Lacy]

Attachment: testing patch

There's no real opportunity in TB3 or I believe FF to test drag and drop of a local file.  This patch creates a fake method.
With this patch installed, in TB3 select a message and drag to the o/s desktop.
The message normal drag is disabled and simply a simple file is created on c:\root directory and the nsIFile is set in the transferable for dragging.

When executed the drag does nothing.
It should drag to drop location.

Comment 2

[Phil Lacy]

Attachment: enable drag if local file

kfilemime is enabled for dragging per https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#file

Comment 3

[Nochum Sossonko [:Natch]]

1.9.1 is out the door already...

Comment 4

[Samuel Sidler (old account; do not CC)]

This isn't going to block 1.9.1.1. Can someone explain why this bug is important enough to take in a maintenance release? Is it a regression from something? It's not clear to me that it shouldn't just be included in 1.9.2...

Comment 5

[Phil Lacy]

Besides to bring up our code to meet the docs on FF 3.5 drag and drop, I have a patch for enhancement bug 462172 that would depend on this bug. That may not qualify for earlier then 1.9.2.

The other bugs in the dependency tree would allow drag and drop images to an image editor like mspaint, like IE.

Comment 6

[Phil Lacy]

Comment on attachment 382912 [details] [diff] [review]
enable drag if local file

I'm going to correct nsDataObj::GetFile() in another bug then resubmit this fix.

Comment 7

[Phil Lacy]

Attachment: fixes previous patch

the temp file was not properly loaded up into windows IDataObject::GetData for files.

Comment 8

[Phil Lacy]

Attachment: patched to trunk

Comment 9

[Phil Lacy]

This is in the middle of a tree of patches so it probably won't get review before 338478. If the other bugs/patches in this tree catch any interest, I can update them after 338478 is resolved.