Closed Bug 497797 Opened 15 years ago Closed 14 years ago

drag and drop local file is not enabled


(Core :: Widget: Win32, defect)

Windows XP
Not set





(Reporter: philbaseless-firefox, Assigned: philbaseless-firefox)




(2 files, 2 obsolete files)

kfilemime (x-mox-file) transferable flavor does not have code to deal with drag and drop.
Attached patch testing patchSplinter Review
There's no real opportunity in TB3 or I believe FF to test drag and drop of a local file.  This patch creates a fake method.
With this patch installed, in TB3 select a message and drag to the o/s desktop.
The message normal drag is disabled and simply a simple file is created on c:\root directory and the nsIFile is set in the transferable for dragging.

When executed the drag does nothing.
It should drag to drop location.
Attached patch enable drag if local file (obsolete) — Splinter Review
kfilemime is enabled for dragging per
Attachment #382912 - Flags: review?(emaijala)
Flags: blocking1.9.1?
1.9.1 is out the door already...
Flags: wanted1.9.1.x?
Flags: blocking1.9.1?
Flags: blocking1.9.1.1?
This isn't going to block Can someone explain why this bug is important enough to take in a maintenance release? Is it a regression from something? It's not clear to me that it shouldn't just be included in 1.9.2...
Flags: blocking1.9.1.1?
Besides to bring up our code to meet the docs on FF 3.5 drag and drop, I have a patch for enhancement bug 462172 that would depend on this bug. That may not qualify for earlier then 1.9.2.

The other bugs in the dependency tree would allow drag and drop images to an image editor like mspaint, like IE.
Flags: wanted1.9.1.x?
Comment on attachment 382912 [details] [diff] [review]
enable drag if local file

I'm going to correct nsDataObj::GetFile() in another bug then resubmit this fix.
Attachment #382912 - Flags: review?(emaijala)
Attached patch fixes previous patch (obsolete) — Splinter Review
the temp file was not properly loaded up into windows IDataObject::GetData for files.
Attachment #382912 - Attachment is obsolete: true
QA Contact: win32 → drag-drop
QA Contact: drag-drop → win32
Blocks: 462172
Attached patch patched to trunkSplinter Review
Attachment #402995 - Attachment is obsolete: true
This is in the middle of a tree of patches so it probably won't get review before 338478. If the other bugs/patches in this tree catch any interest, I can update them after 338478 is resolved.
Closed: 14 years ago
Resolution: --- → DUPLICATE
No longer blocks: 462172
You need to log in before you can comment on or make changes to this bug.