497959 - rename doesn't work with imap fake server

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

I'm tring to get a test working that renames imap folders - I ran into a bunch of issues with fake server - this patch fixes them sufficiently so that I can run my test.

Normally imap servers implement subscription with a separate list of subscribed folders - I don't have time to make fakeserver do that, but it's worth considering. I had to relax some of the error checking in the subscribe and unsubscribe code partly for that reason...

The matchKids stuff defeated me - I'm not really convinced that function does the right thing in general but with my little change, it does the right thing for the use cases our tests generate... things like LSUB "" "/foo/bar.*" don't seem to be implemented, for example, along with the problem I was actually trying to fix...

Comment 1

[Joshua Cranmer [:jcranmer]]

Comment on attachment 382998 [details] [diff] [review]
proposed fix

Per IRC, we came up with what is probably a better form for the matching problem.

The other stuff seems okay to me, though.

Comment 2

[David :Bienvenu]

Attachment: this is the fix jcranmer mentioned over irc - checked in.

this fix does work for me, when combined with my other fixes. I'll put up a patch with just my fixes in a bit...

Comment 3

[David :Bienvenu]

Attachment: rest of fix

Comment 4

[David :Bienvenu]

fix checked in.