497979 - Need access to VMPI_captureStackTrace() and DumpStackTrace() outside of MMgcMemoryProfiler

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: API, defect)

Description

[Jason Williams]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10
Build Identifier: tamarin top of tree

We need to instrument deadlock detection code with stack traces that can be dumped upon detection.  Right now this code is only enabled when MMGC_MEMORY_PROFILER is defined, but, this code is more general purpose and is needed elsewhere. 

This will mean some changes to the stack dump helper routine as well.

Reproducible: Always

Steps to Reproduce:
1. try to use this code outside of the MMgcMemoryProfiler.

Comment 1

[Rishit Shah]

VMPI_captureStackTrace and related symbol lookup functions have no strong tie to MMGC profiler except that the profiler is the only existing consumer.

MMGC_MEMORY_PROFILER is not enabled for Mac because we need to find a way to perform the symbol lookup on release builds.  Otherwise the feature would always be enabled for debug/release builds which would result in availability of stack trace functionality.

These are VMPI_ functions, meaning, they are implemented by the platforms and used by any component.  I think it should be okay to move them outside of MEMORY_PROFILER define and for code savings, on some targets, wrap them under a different feature MMGC_STACK_TRACE, may be.

Regarding DumpStackTraceHelper(), which is just a dumping routine, I am not so sure.  Converting it to VMPI_ does not make sense.  If there was (or is) a util folder that is shared across products then it would probably make sense to put it there.  Else you might have to just dupe the code.  

There might be some other way that Tommy can suggest.

Comment 2

[Jason Williams]

Thanks for the feedback.  I am not advocating turning the dumping routine into a VMPI method, sorry for the confusion there, I just want to have that code refactored so that it can be a generic function available from GC.h or some other suitable location.

Thinking a little more about this, even having a SimpleStack object that is the base class for the current Stack might be nice.  The simple version would only contain the bare minimum for storing the appropriate ip values. Wrapping up the basic functionality into SimpleStack like capturing and dumping a trace would be really beneficial.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.