498075 - Two clicks required to switch windows if a flash video is clicked

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[IU]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090612 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090612 Minefield/3.6a1pre

If a flash video in one window is clicked, it takes two clicks to switch to another window.

This is a regression from  Bug 178324


Reproducible: Always

Steps to Reproduce:
1. Launch Firefox and open a new window, so you have two browser windows.
2. Visit the linked URL (or any flash video site)
3. Click any video to start it playing
4. Wait for the video to load then click the playing video (to focus the flash)
5. Single-click the other browser window
6. Notice that focus snaps back to the video window.  Two clicks are now required to switch windows if a flash video is clicked.  If the video is not clicked, only one click is need to switch windows.

Comment 1

[IU]

*** Another effect of this bug is that, if the window containing the flash video that is clicked is minimized, the window minimizes then maximizes then finally minimizes.

Comment 2

[u88484]

Confirmed.  Note for comment 0, the window with the video has to not be maximised.  So this doesn't happen if you click the firefox window on the taskbar to try and switch windows.

Comment 5

[Neil Deakin]

Attachment: don't move the focus to the parent when blurring a plugin when lowering the window

Comment 6

[Neil Deakin]

Builds are at https://build.mozilla.org/tryserver-builds/[e-mail]-pluginfocus/ for testing

Comment 7

[IU]

(In reply to comment #6)
> Builds are at
> https://build.mozilla.org/tryserver-builds/[e-mail]-pluginfocus/ for
> testing

Patch fixes the bug for me.  Thanks, Neil.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It fixes the bug too. I will also try it with the issue mentioned in bug 498143.

Comment 9

[Neil Deakin]

Checked this in: http://hg.mozilla.org/mozilla-central/rev/b658820cd44d

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks IU for verification. But can you please specify the build id you are testing with the next time? Thanks!

Shouldn't we be able to test this with the test plugin?

Comment 11

[Dão Gottwald [:dao]]

I don't think you'll be able to raise a background window with a synthesized click at all...