Closed Bug 498312 Opened 12 years ago Closed 11 years ago

page style menu should follow the media query spec more closely

Categories

(Firefox :: Menus, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #383241 - Flags: review?(gavin.sharp)
Comment on attachment 383241 [details] [diff] [review]
patch

I spent way too much time trying to figure out why the new code excluding "not all" where the old code didn't wasn't breaking the tests, before realizing that that's what you're fixing and that you're also changing the test's expected results output :(

+    <link data-state="1" href="404.css" title="17" rel="alternate stylesheet" media="foo bar">

+    <link data-state="0" href="404.css" title="21" rel="alternate stylesheet" media="foo">

I don't understand why these are treated differently... seems like the difference is that the latter has media.length == 1, so we check the value, whereas the former has media.length == 0 so we don't check it. Where's the spec for this stuff?
"foo bar" is not a valid media query list (neither is "all screen"), since it lacks the comma: http://www.w3.org/TR/css3-mediaqueries/#syntax
Attachment #383241 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/f565b53ba490
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.