498367 - Dragging a tab into the empty search bar leaves gray emptyText color and doesn't search automatically

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090612 Firefox/3.5 ID:20090612061417

Using d&d to place the url of a tab into the search bar leaves the gray text color of the emptyText when the search bar was empty before.

Steps:
1. Make sure that there is no search term inside the search bar
2. Open at least two tabs
3. D&D one tab into the search bar

The URL is set as search term but the color doesn't change to Black and stays Gray.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That's a regression when comparing it with Firefox 3.0.11.

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

there's also error console output:

Error: transferData.first is null
Source file: chrome://global/content/nsDragAndDrop.js
Line: 470
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/nsDragAndDrop.js#470
unsure if its related though.

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

another outcome of this bug is, that if you switch the search provider after step 3 from comment 0, the search term is cleared. i presume, that the dragged text is somehow not recognized as a proper search term (opposed to typing it manually).

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

ok,
regressed on MC in range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85bd18f6b652&tochange=be12595f2d01

regressed on 1.9.1 in range: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=43d7823fd64d&tochange=0ac64f9870d4

=> overlap gives regression by checkin of Bug 475066
(see https://bugzilla.mozilla.org/show_bug.cgi?id=475066#c32 (MC) & https://bugzilla.mozilla.org/show_bug.cgi?id=475066#c59 (1.9.1) for checkin dates)

unsure if a possible fix would qualify for 1.9.1.x.

Comment 6

[Ria Klaassen (not reading all bugmail)]

In addition it doesn't go automatically to the search results page anymore.

Comment 7

[Samuel Sidler (old account; do not CC)]

This isn't a critical issue, so we won't block 1.9.1.1 on this, though we'll consider a safe fix if one appears. Feel free to renominate if you disagree.

Comment 10

[Michelle Funches - QA]

Cannot reproduce
Version 	47.0.1
Build ID 	20160623154057
User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0