498373 - double-click select selects wrong area with tabs earlier on line

Status: VERIFIED FIXED

(Skywriter Graveyard :: Editor, defect)

Description

[Alex Iskander]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/530.17 (KHTML, like Gecko) Version/4.0 Safari/530.17
Build Identifier: dfd4e61c8c5e

If there are tabs earlier on the line, double-clicking to select a word selects the wrong area because it uses the editor position instead of the model position.

Reproducible: Always

Steps to Reproduce:
1. Make sure tabmode is on.
2. Make a line with a few tabs on it (real tabs), followed by some words separated by spaces.
3. Double click on one of the words.
Actual Results:  
The word is not selected; instead, an earlier or later area is.

Expected Results:  
The word should be selected.

I have fixed this in my repository, along with several other things, including the deleteSelection undo bug. Further, the double (and triple) click select functionality now allows dragging.

http://bitbucket.org/alexi/bespin-fixes/

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

This is indeed a bug, so confirming.

Also, triaging to Editor.

Comment 2

[Dion Almaer]

Applied to b48bdca75f7b

Comment 3

[Gordon P. Hemsley [:GPHemsley]]

More specifically, this was fixed in changeset 2f86b3d021b8. Marking as VERIFIED.

However, triple-click to select the whole line has this exact same problem.

Comment 4

[Alex Iskander]

Triple-click select was not converting model positions to cursor positions. I have fixed this now in my repository (and also cleaned up the code a bit by using the editor's helper proxies for a few functions).

http://bitbucket.org/alexi/bespin-fixes/

Comment 5

[Alex Iskander]

I believe this is in tip now, so I'm resolving.