498440 - [DXR] Add xpidl_xref for data extraction from idl

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[David Humphrey (:humph)]

Attachment: xpidl_xref patch

In order to obtain proper loc and naming info from idl, dxr uses xpidl_xref.  Currently I do this by writing my own rule for idl generation in a myrules file, and patch my tree's xpcom/typelib/xpidl.  However, if this is something we can take in the tree, it makes it easier to do this without having to alter your tree or build system.

Ted first started this, and I've extended it.  There are still a few cases I don't handle yet, for example inline C++.  But most of it is done now.

Comment 1

[David Humphrey (:humph)]

Attachment: patch v2

Same patch, but all uses of _line are replaced with _line - 1 in order to fix the fact that I'm off by one whenever I don't.

Comment 2

[David Humphrey (:humph)]

Benjamin, should we consider changing reviewers on this to Ted instead of you?

Comment 3

[Benjamin Smedberg]

Attachment: xpidl-xref.py, rev. 1

How about this instead? There may be something missing for typedefs, because I didn't get any sample output for that, but I think this matches the sample output that I saw.

Comment 4

[Joshua Cranmer [:jcranmer]]

Not necessary for DXR anymore (with the python parser and some myrules.mk changes, there's no need to modify mozilla's build system).