Closed
Bug 498496
Opened 16 years ago
Closed 16 years ago
assertion search on custom header when header has empty value
Categories
(MailNews Core :: Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: Bienvenu, Assigned: Bienvenu)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
1.47 KB,
patch
|
rkent
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
|
5.41 KB,
patch
|
Details | Diff | Splinter Review |
trying to get rid of all those bugzilla notifications, I did an advanced search on a bugzilla header, and got a ton of assertions. So I removed the assertion and added a couple comments.
Attachment #383364 -
Flags: superreview?(neil)
Attachment #383364 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Attachment #383364 -
Flags: superreview?(neil)
Attachment #383364 -
Flags: superreview+
Attachment #383364 -
Flags: review?(neil)
Attachment #383364 -
Flags: review?(kent)
|
||
Comment 1•16 years ago
|
||
I seem to recall on IRC that Neil and David discussed that it is currently possible, in theory, to define a test for empty header as Is "". It seems to me that if you fix the assertion, you should also make the test itself work.
The attached unit test fails on the assertion before bienvenu's patch, but fails on the Is "" with his patch. Can you make this work? Or should that be another bug?
|
Assignee | |
Comment 2•16 years ago
|
||
that's an other bug - I'm just trying to quiet an assertion...
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 383364 [details] [diff] [review]
proposed fix
OK, I added bug 498728 with the failing Is "" case. I looked for and could not find a dupe.
Attachment #383364 -
Flags: review?(kent) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•