assertion search on custom header when header has empty value

RESOLVED FIXED in Thunderbird 3.0b3

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 3.0b3
x86
Windows Vista

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 383364 [details] [diff] [review]
proposed fix

trying to get rid of all those bugzilla notifications, I did an advanced search on a bugzilla header, and got a ton of assertions. So I removed the assertion and added a couple comments.
Attachment #383364 - Flags: superreview?(neil)
Attachment #383364 - Flags: review?(neil)

Updated

10 years ago
Attachment #383364 - Flags: superreview?(neil)
Attachment #383364 - Flags: superreview+
Attachment #383364 - Flags: review?(neil)
Attachment #383364 - Flags: review?(kent)
Created attachment 383519 [details] [diff] [review]
unit test, fails with Is ""

I seem to recall on IRC that Neil and David discussed that it is currently possible, in theory, to define a test for empty header as Is "". It seems to me that if you fix the assertion, you should also make the test itself work.

The attached unit test fails on the assertion before bienvenu's patch, but fails on the Is "" with his patch. Can you make this work? Or should that be another bug?
(Assignee)

Comment 2

10 years ago
that's an other bug - I'm just trying to quiet an assertion...

Updated

10 years ago
Blocks: 498728
Comment on attachment 383364 [details] [diff] [review]
proposed fix

OK, I added bug 498728 with the failing Is "" case. I looked for and could not find a dupe.
Attachment #383364 - Flags: review?(kent) → review+
(Assignee)

Comment 4

10 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.