Created attachment 383364 [details] [diff] [review] proposed fix trying to get rid of all those bugzilla notifications, I did an advanced search on a bugzilla header, and got a ton of assertions. So I removed the assertion and added a couple comments.
Created attachment 383519 [details] [diff] [review] unit test, fails with Is "" I seem to recall on IRC that Neil and David discussed that it is currently possible, in theory, to define a test for empty header as Is "". It seems to me that if you fix the assertion, you should also make the test itself work. The attached unit test fails on the assertion before bienvenu's patch, but fails on the Is "" with his patch. Can you make this work? Or should that be another bug?
that's an other bug - I'm just trying to quiet an assertion...
Comment on attachment 383364 [details] [diff] [review] proposed fix OK, I added bug 498728 with the failing Is "" case. I looked for and could not find a dupe.
Attachment #383364 - Flags: review?(kent) → review+
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.