Closed Bug 498562 Opened 13 years ago Closed 13 years ago

[FIX]Avoid Expand/Compress cycle for inline style sets

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Now with missing ClearPropertyBit call
11.66 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
One obvious cost when setting inline style is the Expand/Compress we end up doing on the inline style in the process.  We don't _really_ need to do it in many cases, and not doing it is a 30% win on my inline style microbenchmark (in the url field) and about an 8-10% win on "real-life" testcases (the bugs this blocks).

I'm not quite sure what I think of this approach, but I do think it's pretty safe and makes a noticeable performance difference.
Attached patch Proposed fix (obsolete) — — Splinter Review
Attachment #383411 - Flags: superreview?(dbaron)
Attachment #383411 - Flags: review?(dbaron)
Attachment #383411 - Attachment is obsolete: true
Attachment #383418 - Flags: superreview?(dbaron)
Attachment #383418 - Flags: review?(dbaron)
Attachment #383411 - Flags: superreview?(dbaron)
Attachment #383411 - Flags: review?(dbaron)
Comment on attachment 383418 [details] [diff] [review]
Now with missing ClearPropertyBit call

+ * An |nsCSSCompressedDataBlock| holds a usuallu-immutable chunk of

usually

+    // return null.  Must notbe called for shorthand properties.

not be


r=dbaron
Attachment #383418 - Flags: superreview?(dbaron)
Attachment #383418 - Flags: review?(dbaron)
Attachment #383418 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/d8917fe0ed6a with those comment changes.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.