498609 - Cannot focus location bar after cancelling/pausing a download

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[philippe (part-time)]

STR
1. start downloading a file 
2. download manager opens in front of main window
3. cancel or pause the download
4. switch to main window

At this point it is impossible
* to focus and input something the location or search bar (I normally use the keyboard shortcut, but mouse click fails)
* to set focus in a form field.

fails
20090610110529-cabb8925dcd3-firefox-3.6a1pre.en-US.mac.dmg   
10-Jun-2009
works     
20090610090902-1057ca8f2a91-firefox-3.6a1pre.en-US.mac.dmg   
10-Jun-2009

--> bug 178324

note
1. right-click on a file in the download manager doesn't seem to cause problems
2. I have have experienced a similar issue (I think) while debugging a webpage and switching between 2 tabs - possibly having used Firebug. But I could not reproduce that.

Comment 1

[Neil Deakin]

Attachment: fix

Seems to work but can't figure out how to get a test for it

Comment 2

[Neil Deakin]

Attachment: include a test

Clear out mFocusedContent if it isn't in a document. This problem occurs when a focused element is in a binding which goes away.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 383710 [details] [diff] [review]
include a test

> PRBool
> nsFocusManager::Blur(nsPIDOMWindow* aWindowToClear,
>                      nsPIDOMWindow* aAncestorWindowToFocus,
>                      PRBool aIsLeavingDocument)
> {
Please document in .h what the return value means.

>+<window title="Focus Switch Binding Test"
>+        onload="setTimeout(switchBinding, 0);"
Could you perhaps move this timeout to the ctor of the first binding, after
.focus()?

Comment 4

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/45cf3a994809