Closed
Bug 49868
Opened 24 years ago
Closed 23 years ago
We need to display an error message during GetMsg when the disk is full
Categories
(SeaMonkey :: MailNews: Message Display, defect, P2)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: bugzilla, Assigned: naving)
References
Details
(Keywords: helpwanted, Whiteboard: [rtm-] relnote-user UE1)
Attachments
(1 file)
1.55 KB,
patch
|
bugzilla
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
Now that we have disk full detection (see bug 32443), GetMsg will eventually failed if the user's hard drive has not enough free space but we are not displaying an error.
Comment 1•24 years ago
|
||
Adding myself to cc, moving the keywords into the correct field (They were in the URL field before), adding UE1, and changing component to Mail Window Front End (I think the handler for this needs to be higher then the networking layer). Basically, whoever calls nsIPop3Sink (or is it nsIPop3Listener ?) needs to handle the possibility of a MK_POP3_OUT_OF_DISK_SPACE error being passed back to it. I'll look at this one later tonight.
URL: correctness, nsbeta3
Component: Networking - POP → Mail Window Front End
- per mail triage. jce2@po.cwru.edu - if you want to take this and fix, please do so and go through the Mozilla review/approval process.
Keywords: helpwanted
Whiteboard: [nsbeta3-]
Comment 3•24 years ago
|
||
When this error occurs on the backend, how is it handled today? Does it abort the download and leave the message(s) on the server? Is there any case where we lose messages because of this error (in particular given that we don't display the error message currently?)
As I remembered from 4.x and assuming that we didn't make a lot of changes (logic-wise), we do abort the download and leave the message on the server. We should lose any data.
Reporter | ||
Comment 5•24 years ago
|
||
If I have correctly understood the jce2's fix (see bug 32443), before downloading message, we check if we have enough space. If not, we don't event start the download we just abort. We don't loose any message but we don't receive any one either.
Comment 6•24 years ago
|
||
I'm having trouble figuring out where I'm supposed to place the handler. From my tracing of what calls GetMsg, i'm not finding any procedures that are actually checking their return values. I'm afraid of placing the handler in the wrong place, and getting it in some cases, not getting it in other cases. I need help. Adding keyword RTM.
Keywords: rtm
Whiteboard: [nsbeta3-] → [nsbeta3-] AT RISK, CAN'T FIND WHERE IT NEEDS TO GO!
Comment 7•24 years ago
|
||
Jeff, can you help determine where this fix would go?
Whiteboard: [nsbeta3-] AT RISK, CAN'T FIND WHERE IT NEEDS TO GO! → [nsbeta3-][rtm need info] AT RISK, CAN'T FIND WHERE IT NEEDS TO GO!
I think we need to make sure couple things: 1) the dataSource.DoCommand() needs to be able to return error code (I believe it does, but noone try to pay attention to it) 2) we need to revise GetNewMessage() & DoRDFCommand() in mailCommands.js to pay attention to the error condition returned back from the backend. Does this help?
Updated•24 years ago
|
Keywords: relnoteRTM
Whiteboard: [nsbeta3-][rtm need info] AT RISK, CAN'T FIND WHERE IT NEEDS TO GO! → [nsbeta3-][rtm-]
Comment 9•24 years ago
|
||
rtm-, we believe the incidence of this problem is only going to recede with time as disks climb into higher and higher GB ranges. Adding relnotertm keyword.
Comment 10•24 years ago
|
||
An update (fully explained in reopened bug 32443): POP user who does not have "leave on server" enabled in account settings will lose messages which are retrieved in out of disk space condition.
QA Contact: lchiang → laurel
Updated•24 years ago
|
Whiteboard: [nsbeta3-][rtm-] → [nsbeta3-][rtm-] relnote-user
Comment 12•24 years ago
|
||
Now that I don't have to deal with the PDT, I'll start working on this for mozilla 0.9
Keywords: mozilla0.9
Comment 13•24 years ago
|
||
Whenever this is fixed, see related bugs for verification cases: bug 57902, bug 55814, bug 32443...
Comment 14•24 years ago
|
||
reassigning jefft's bugs to naving
Assignee: jefft → naving
Status: ASSIGNED → NEW
Assignee | ||
Comment 15•23 years ago
|
||
I believe we don't do this, but this should be simple and it should have been there in first place.
Keywords: nsbeta1
Updated•23 years ago
|
Comment 16•23 years ago
|
||
Taking a stab at the text for the error message: "There is not enough disk space to download new messages. Try deleting old mail, emptying the Trash folder, and compacting your mail folders, and then try again."
Updated•23 years ago
|
Priority: P3 → P2
Comment 17•23 years ago
|
||
Is this really a nsbeta1+, P2, but marked Future, we should either nsbeta1- it, or change its priority, so it gets off our tracking lists.
Assignee | ||
Comment 18•23 years ago
|
||
Throw alert before bailing out. Alert wording as suggested by robin
Reporter | ||
Comment 19•23 years ago
|
||
Comment on attachment 68600 [details] [diff] [review] proposed fix Looks good. R=ducarroz
Attachment #68600 -
Flags: review+
Updated•23 years ago
|
Attachment #68600 -
Flags: superreview+
Comment 20•23 years ago
|
||
Comment on attachment 68600 [details] [diff] [review] proposed fix sr=mscott
Assignee | ||
Comment 21•23 years ago
|
||
fixed
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 22•23 years ago
|
||
OK using mar26 commercial trunk build on linux rh6.2. Alert displays with text as suggested by Robin in comment #16.
Comment 23•23 years ago
|
||
Proper alert displays when getting mail using win98 and apr8 commercial trunk build. Marking this bug verified. Assuming Mac OS is okay.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•