498700 - imip bar is not displayed, error "GetLoadedMessage is not defined" in imip-bar.js

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0pre (BuildID: 20090616094218) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090616 Shredder/3.0b3pre

Selecting an email message containing an invitation throws the following error in console, imip bar with accept/decline button is not visible:

Error: GetLoadedMessage is not defined
Source File: chrome://lightning/content/imip-bar.js
Line: 49

Comment 1

[Stefan Sitter [:ssitter]]

According to mxr the function existed in the 1.8.1 Thunderbird builds:
  http://mxr.mozilla.org/mozilla1.8/ident?i=GetLoadedMessage

But it doesn't exist on the 1.9.1 Thunderbird builds anymore:
  http://mxr.mozilla.org/comm-central/ident?i=GetLoadedMessage

Comment 2

[Stefan Sitter [:ssitter]]

The GetLoadedMessage() was removed with the checkin from Bug 474701 four days ago: <https://hg.mozilla.org/comm-central/rev/b0e37b312b54>

Comment 3

[Stefan Sitter [:ssitter]]

According to IRC "gFolderDisplay.selectedMessage" might work. But it returns a MsgHdr instead of a MsgURI. <https://developer.mozilla.org/en/Extensions/Thunderbird/HowTos#Thread_Pane> has some details.

Comment 4

[Martin Schröder [:mschroeder]]

(In reply to comment #3)
> According to IRC "gFolderDisplay.selectedMessage" might work. But it returns a
> MsgHdr instead of a MsgURI.
> <https://developer.mozilla.org/en/Extensions/Thunderbird/HowTos#Thread_Pane>
> has some details.

or "gMessageDisplay.displayedMessage"? Does this also work in the (standalone) message window?

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 384252 [details] [diff] [review]
Patch v1

Codewise this looks ok, r=philipp

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/963ded786cb7>

-> FIXED

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".