498708 - Open URL in Camino service name not localizable

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I noticed while looking at the Chinese 1.6.x that other apps' Services displayed in the menu with localized names, while ours doesn't.

We should just need to add that string to InfoPlist.strings for 2.0.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Probable fix

This should be the right fix (it's certainly what Safari does); unfortunately, I've been unable to test because I haven't figured out the right magic incantation to rebuild the Services menu using the current Camino and I have far too many copies of Camino running around :-(

Comment 2

[Stuart Morgan]

Comment on attachment 383606 [details] [diff] [review]
Probable fix

According to
http://developer.apple.com/documentation/Cocoa/Conceptual/SysServices/Concepts/properties.html
we should be using a file call ServicesMenu.strings for this. Safari actually has that as well, and that's what a bunch of other Apple apps I spot-checked do.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Probable fix, v2

Switches to ServicesMenu.strings and hooks that file up to the strings-generation stuff (and adds both the .in and the generated/ file to the project).

I still can't trigger this; I don't know if the Services menu is generated at startup and cached (in addition to my having too many Caminos) or what :-(

Comment 4

[Stuart Morgan]

Comment on attachment 385270 [details] [diff] [review]
Probable fix, v2

sr=smorgan

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.