Open URL in Camino service name not localizable

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

Details

(Whiteboard: l10n)

Attachments

(1 attachment, 1 obsolete attachment)

I noticed while looking at the Chinese 1.6.x that other apps' Services displayed in the menu with localized names, while ours doesn't.

We should just need to add that string to InfoPlist.strings for 2.0.
Created attachment 383606 [details] [diff] [review]
Probable fix

This should be the right fix (it's certainly what Safari does); unfortunately, I've been unable to test because I haven't figured out the right magic incantation to rebuild the Services menu using the current Camino and I have far too many copies of Camino running around :-(
Attachment #383606 - Flags: superreview?(stuart.morgan+bugzilla)

Updated

10 years ago
Attachment #383606 - Flags: superreview?(stuart.morgan+bugzilla) → superreview-

Comment 2

10 years ago
Comment on attachment 383606 [details] [diff] [review]
Probable fix

According to
http://developer.apple.com/documentation/Cocoa/Conceptual/SysServices/Concepts/properties.html
we should be using a file call ServicesMenu.strings for this. Safari actually has that as well, and that's what a bunch of other Apple apps I spot-checked do.
Created attachment 385270 [details] [diff] [review]
Probable fix, v2

Switches to ServicesMenu.strings and hooks that file up to the strings-generation stuff (and adds both the .in and the generated/ file to the project).

I still can't trigger this; I don't know if the Services menu is generated at startup and cached (in addition to my having too many Caminos) or what :-(
Attachment #383606 - Attachment is obsolete: true
Attachment #385270 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 4

9 years ago
Comment on attachment 385270 [details] [diff] [review]
Probable fix, v2

sr=smorgan
Attachment #385270 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.