498818 - spaces in Stack Signature field mis-encoded into pluses + instead of %20, leading to no results found

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1) Click the "Advanced Filters" link
2) Try to query the "Stack Signature" field for all Camino 2.0b3 reports whose stack sig contains "-[NSWindow makeKeyWindow]" by pasting or typing "-[NSWindow makeKeyWindow]" into the field
2) Click the "Filter Crash Reports" pseudo-button

ER: http://crash-stats.mozilla.com/query/query?do_query=1&product=Camino&version=Camino%3A2.0b3&platform=mac&date=&range_value=2&range_unit=weeks&query_search=signature&query_type=contains&query=-[NSWindow%20makeKeyWindow] showing several signatures with "-[NSWindow makeKeyWindow]"

AR: http://crash-stats.mozilla.com/query/query?do_query=1&product=Camino&version=Camino%3A2.0b3&platform=mac&date=&range_value=2&range_unit=weeks&query_search=signature&query_type=contains&query=-[NSWindow+makeKeyWindow] showing no results at all :(

Comment 1

[Austin King [:ozten]]

Code is on stage. Please test for regressions.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> Code is on stage. Please test for regressions.

Austin, where's stage, or was that comment meant for someone other than me?

Comment 3

[Samuel Sidler (old account; do not CC)]

http://crash-stats.stage.mozilla.com/

Comment 4

[Austin King [:ozten]]

(In reply to comment #2)
Thanks for looking at this. Be sure to set the "Advanced Filters" to Within the Last 2 weeks, instead of default 1 week, as there isn't much data in the system.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yeah, this seems to work OK based on the limited amount of data available, i.e. with "strcmp | libvlc.dll" (there are no Cocoa stacks in the dataset, so I can't verify that something like "-[NSWindow sendEvent:]" has no regressions in the other characters).  

While the URL still contains a + for every space, that URL's query now properly returns results and the "Stack Signature" field also still shows the spaces after initial submission instead of converting them to +. :-)