499092 - Prefixed XML namespace (xhtml)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Laurent Fournier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090617 Shiretoko/3.5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090617 Shiretoko/3.5pre

The xhtml title tag reports a Window title in FF only if the namespace is not prefixed.
I don't know if this bug is limited to xhtml or also found in any namespace.

Reproducible: Always

Steps to Reproduce:
Load the two following XML files in FF:

<?xml version="1.0"?>
<doc xmlns:aa="http://www.w3.org/1999/xhtml">
<aa:title>OK</aa:title>
</doc>

<?xml version="1.0"?>
<doc xmlns="http://www.w3.org/1999/xhtml">
<title>OK</title>
</doc>
Actual Results:  
The second file displays a 'OK' window title in FF while the first file does not display any title.

Expected Results:  
A window title with a xhtml prefixed namespace

I need a prefix because I am using several namespaces (xhtml+xlink) in my real application and I did not found a workarround to make clicable xlink in a xhtml document.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 425716 [details] [diff] [review]
Patch

>diff -r 92d646229908 -r 14846ba17b53 content/base/src/nsDocument.cpp
>--- a/content/base/src/nsDocument.cpp	Sun Feb 07 14:47:06 2010 +0100
>+++ b/content/base/src/nsDocument.cpp	Sun Feb 07 19:48:27 2010 +0100
>@@ -5039,17 +5039,17 @@ nsDocument::GetTitleContent(PRUint32 aNa
>   // <title> element has been bound to this document. So if it's false,
>   // we know there is nothing to do here. This avoids us having to search
>   // the whole DOM if someone calls document.title on a large document
>   // without a title.
>   if (!mMayHaveTitleElement)
>     return nsnull;
> 
>   nsRefPtr<nsContentList> list =
>-    NS_GetContentList(this, nsGkAtoms::title, kNameSpaceID_Unknown);
>+    NS_GetContentList(this, nsGkAtoms::title, kNameSpaceID_Wildcard);

Just pass in aNamespace as third argument. That way you can just grab the first element in the resulting list and not have to loop through to find one with the appropriate namespace.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

With comment addressed

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 426315 [details] [diff] [review]
Patch v2

Thanks! Looks great!

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

What name do you want me to use as the patch author for the checkin comment?

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

"Ms2ger", please. Thanks for your time!

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Thanks for the patch, sorry it took so long to get checked in.

http://hg.mozilla.org/mozilla-central/rev/e75531fda63e