Closed
Bug 499229
Opened 15 years ago
Closed 4 years ago
Should the warning "nsBlockFrame::CheckFloats: Explicit float list is out of sync with float cache" become an assertion?
Categories
(Core :: Layout: Floats, enhancement)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
84 Branch
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: jruderman, Assigned: TYLin)
References
Details
Attachments
(1 file)
At one point, the testcase in bug 417902 triggered: WARNING: nsBlockFrame::CheckFloats: Explicit float list is out of sync with float cache: file /mozilla/layout/generic/nsBlockFrame.cpp, line 6755 In bug 417902 comment 5, roc said "That's pretty bad actually ... can probably lead to a crash somehow or other". Should it be an assertion (or even an abort), then?
|
Reporter | |
Comment 1•15 years ago
|
||
Changing it to an assertion will make me notice it while fuzzing, and soon will make Tinderboxen notice it while running unit tests.
We're actually just planning to remove the float cache so this will be a non-issue.
Depends on: 498986
|
Assignee | |
Comment 3•4 years ago
|
||
Float cache is still there, so let's turn the warning into an assertion to make it more explicit. The warning does show up while fuzzing as noticed by Mats in bug 1671527 Comment 6.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9182776 -
Attachment description: Bug 499229 - Change NS_WARNING in nsBlockFrame::CheckFloats to NS_ASSERTION. → Bug 499229 - Change NS_WARNING in nsBlockFrame::CheckFloats to NS_ERROR.
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e88986658685 Change NS_WARNING in nsBlockFrame::CheckFloats to NS_ERROR. r=mats
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•