499229 - Should the warning "nsBlockFrame::CheckFloats: Explicit float list is out of sync with float cache" become an assertion?

Status: RESOLVED FIXED

(Core :: Layout: Floats, enhancement)

Description

[Jesse Ruderman]

At one point, the testcase in bug 417902 triggered:

WARNING: nsBlockFrame::CheckFloats: Explicit float list is out of sync with
float cache: file /mozilla/layout/generic/nsBlockFrame.cpp, line 6755

In bug 417902 comment 5, roc said "That's pretty bad actually ... can probably lead to a crash somehow or other".

Should it be an assertion (or even an abort), then?

Comment 1

[Jesse Ruderman]

Changing it to an assertion will make me notice it while fuzzing, and soon will make Tinderboxen notice it while running unit tests.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We're actually just planning to remove the float cache so this will be a non-issue.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Float cache is still there, so let's turn the warning into an assertion to make it more explicit. The warning does show up while fuzzing as noticed by Mats in bug 1671527 Comment 6.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 499229 - Change NS_WARNING in nsBlockFrame::CheckFloats to NS_ERROR.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e88986658685
Change NS_WARNING in nsBlockFrame::CheckFloats to NS_ERROR. r=mats

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e88986658685