499231 - Download button says Firefox version "3.0.11-08"

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Chris Ilias [:cilias]]

Go to http://www.mozilla.com/en-US/firefox/ and look for the green download box. The version number offered is "3.0.11-08". I don't see any such version on the FTP server, so I figured that it's a website bug.

Comment 1

[Chris Ilias [:cilias]]

Attachment: screenshot

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

That's from the Funnelcake build, which will be disabled at midnight tonight. Sounds like the website needs a fix though.

Comment 3

[Samuel Sidler (old account; do not CC)]

I was just going to say that! :(

Comment 4

[Chris Ilias [:cilias]]

Someone just pointed out to me that this also breaks the relnotes link.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

URL is actually http://www.mozilla.com/en-US/firefox/personal.html.

Comment 6

[Samuel Sidler (old account; do not CC)]

fwiw: Even when Funnelcake is over later today, we should get this fixed so it doesn't happen the next time we ship a Funnelcake build.

Comment 7

[Fred Wenzel [:wenzel]]

Does this happen all over the website, or just on the newly-"funnelcaked" "personal" page?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Does this happen all over the website, or just on the newly-"funnelcaked"
> "personal" page?

It happened just on that page.

Comment 9

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Our replacement pattern was a little too greedy. This should do the trick by just replacing parts of the download URLs, but not all instances of the version number.

Comment 10

[Wil Clouser [:clouserw]]

Comment on attachment 384176 [details] [diff] [review]
Patch, rev. 1

good work

Comment 11

[Fred Wenzel [:wenzel]]

This has landed on trunk in r28263. Will push it to staging/prod shortly so it's not forgotten for the next funnelcake run.

Comment 12

[Fred Wenzel [:wenzel]]

I pushed it to staging, but it won't show up in the prod queue quite yet, so I'll have to try pushing it live tomorrow.

Comment 13

[Fred Wenzel [:wenzel]]

After a second try, Kubla had mercy with me. This is live now.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Squire Raymond and I verily verified this bug during tonight's Funnelcake '09 push.