Closed Bug 499275 Opened 12 years ago Closed 12 years ago

nsIMsgProgress:getPrompter always returns null

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
I just spotted this as part of the work I'm doing on cleaning up the send listeners. In nsMsgProgress, m_dialog is never set to anything - it always is null, as a result, nsIMsgProgress::getPrompter will also always return null.

As I don't see much use for nsIMsgProgress to have a prompter, and I think we'll be redoing how some of this feedback works, I think it is safe just to drop it rather than fix it.

I'm also removing the nsIMsgComposeProgress interface as that isn't even compiled let alone referenced.
Flags: in-testsuite-
Attachment #384073 - Flags: superreview?(bienvenu)
Attachment #384073 - Flags: review?(bienvenu)
Attachment #384073 - Flags: superreview?(bienvenu)
Attachment #384073 - Flags: superreview+
Attachment #384073 - Flags: review?(bienvenu)
Attachment #384073 - Flags: review+
Checked in: http://hg.mozilla.org/comm-central/rev/739481e2e5cc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.