4993 - NECKO: [PP]local directory load fails

Status: VERIFIED DUPLICATE of bug 6936

(Core :: Networking: File, defect, P3)

Description

[Robert Sim]

I'm a newbie, so forgive me if I've got the wrong component (libfileurl).
When loading a local directory,
network/protocol/file/mkfile.c : net_read_directory_chunk( )
makes the following call:
PL_strcpy(full_path, con_data->filename + 1)
which effectively removes the leading '/' from the filename.  This causes the subsequent PR_GetFileInfo to fail, and the directory reads as empty.

The easy fix is to remove the + 1, which seems to work for me, but of course this may cause problems elsewhere.

Comment 1

[Robert Sim]

Attachment: Proposed patch

Comment 2

[Robert Sim]

Sorry, bugzilla didn't give me a chance to comment on the patch- It's motivated
by the code in net_open_directory( ) which essentially handles the same problem.
The fix works fine on my linux box, but I can't comment about other platforms.

Comment 3

[Gagan]

Deffered till Necko lands...

Comment 4

[Gagan]

Deferring till Necko lands...

Comment 5

[Gagan]

Per DP's suggestion marking these till M8. Though Necko lands with M7, we will
be able to verify it for M8.

Comment 6

[James Everingham]

I'm moving this to target M9, Necko will be enabled somewhere during late M8 or
early M9.  We will need to get on this and it cannot be postponed past the M9
milestone.

Comment 7

[leger]

Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)

Comment 8

[Gagan]

Pl. verify with Necko.

Comment 9

[Paul MacQuiddy]

this is a file:// problem, which doesn't seem to be working at all on unix.
Loading any type of local directory on Linux just brings up a empty dialogue
box. Same thing on windows, but the dialogue is not empty, it's the file
download dialogue.
I think Warren was working on this. Changing Component to Necko.

Comment 10

[Warren Harris]

The original bug specified here is long gone, but it sounds like the new bug is
that local directory listings aren't generated. Perhaps we should close this
bug and file a new one specifically about that. I thought I recalled seeing one
on that already though.

Comment 11

[Paul MacQuiddy]

yes, you're right. 6936 is the almighty file:// URL's don't work bug. Marking
this one a dup

*** This bug has been marked as a duplicate of 6936 ***

Comment 12

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.