499509 - TM: Tracemonkey doesn't build on VS2005 with tracevis option

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Leandro Lameiro]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090616 Firefox/3.5
Build Identifier: tracemonkey hg tip

Tracemonkey with tracevis doesn't compile on VS 2005.
Here is the commit and the problematic line: http://hg.mozilla.org/tracemonkey/rev/d896fc27a7e5#l4.62
It is a compile error. VS 2005 doesn't support literals like 0x1fllu, because of the LLU suffix, which is not supported. See VS bugtracker: http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=308123


Reproducible: Always

Actual Results:  
Tracemonkey doesn't compile with tracevis enabled.

Comment 1

[David Mandelin [:dmandelin]]

It works for me. I think I'm running VS2005 with SP1. Here is my info block from "About Microsoft Visual Studio":

Microsoft Visual Studio 2005
Version 8.0.50727.867  (vsvista.050727-8600)
Microsoft .NET Framework
Version 2.0.50727 SP2

Installed Edition: Professional

Microsoft Visual Basic 2005   77626-009-0000007-41678
Microsoft Visual Basic 2005

Microsoft Visual C# 2005   77626-009-0000007-41678
Microsoft Visual C# 2005

Microsoft Visual C++ 2005   77626-009-0000007-41678
Microsoft Visual C++ 2005

Microsoft Visual J# 2005   77626-009-0000007-41678
Microsoft Visual J# 2005

Microsoft Visual Web Developer 2005   77626-009-0000007-41678
Microsoft Visual Web Developer 2005

Microsoft Web Application Projects 2005   77626-009-0000007-41678
Microsoft Web Application Projects 2005
Version 8.0.50727.867

Crystal Reports    AAC60-G0CSA4B-V7000AY
Crystal Reports for Visual Studio 2005


Hotfix for Microsoft Visual Studio 2005 Professional Edition - ENU (KB935225)   
This Hotfix is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Hotfix will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/935225

Hotfix for Microsoft Visual Studio 2005 Professional Edition - ENU (KB943969)   
This Hotfix is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Hotfix will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/943969

Hotfix for Microsoft Visual Studio 2005 Professional Edition - ENU (KB947315)   
This Hotfix is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Hotfix will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/947315

Intel(R) C++ Compiler Integration   Package ID: w_cproc_p_11.0.061
Intel(R) C++ Compiler Integration for Microsoft Visual Studio* 2005, Version 11.0.744.2005 , Copyright (C) 2002-2008 Intel Corporation.
* Other names and brands may be claimed as the property of others

Intel(R) VTune(TM) Performance Analyzer   
Intel(R) VTune(TM) Performance Analyzer 9.1
Build:187
Copyright (C) 2000-2008 Intel Corporation. All rights reserved.
Portions Copyright (C) 1999, 2001 VideoSoft
Warning: This computer program is protected under U.S. and international copyright laws, and may only be used or copied in accordance with the terms of the license agreement.  Except as permitted by such license, no part of this computer program may be reproduced, stored in a retrieval system, or transmitted in any form or by any means without the express written consent of Intel Corporation.

For technical support please visit:
http://support.intel.com/support/performancetools/vtune/

Intel® Thread Profiler   
Intel® Thread Profiler 3.1
Build:0.26511
Copyright © 2001-2007 Intel Corporation. All rights reserved.
Warning:This computer program is protected under U.S. and international copyright laws, and may only be used or copied in accordance with the terms of the license agreement.  Except as permitted by such license, no part of this computer program may be reproduced, stored in a retrieval system, or transmitted in any form or by any means without the express written consent of Intel Corporation.

For technical support please visit:
http://support.intel.com/support/performancetools/vtune/

Microsoft Visual Studio 2005 Professional Edition - ENU Service Pack 1 (KB926601)   
This service pack is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this service pack will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/926601

Security Update for Microsoft Visual Studio 2005 Professional Edition - ENU (KB937061)   
This Security Update is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Security Update will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/937061

Security Update for Microsoft Visual Studio 2005 Professional Edition - ENU (KB947738)   
This Security Update is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Security Update will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/947738

Security Update for Microsoft Visual Studio 2005 Professional Edition - ENU (KB971090)   
This Security Update is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Security Update will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/971090

Update for Microsoft Visual Studio 2005 Professional Edition - ENU (KB932232)   
This Update is for Microsoft Visual Studio 2005 Professional Edition - ENU. 
If you later install a more recent service pack, this Update will be uninstalled automatically. 
For more information, visit http://support.microsoft.com/kb/932232

Comment 2

[Mark Steele]

This should have been fixed in my patch on bug 499509. I was going to re-confirm and close but I was hoping someone else could test too. Looks like it's fixed.

Comment 3

[Leandro Lameiro]

Hi David.

It wasn't compiling before. One of the Ethogram patches from Mark fixed this. We can close the bug now.

Comment 4

[Mark Steele]

I assume the last comment collided with mine and reopened this. I'm going to close again.