499540 - Multiweek View: changing Number of Weeks via View menu fails

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090621 Calendar/1.0pre (BuildID: 20090621002041)

Steps to Reproduce:
1. Start Sunbird
2. Switch to Multiweek View
3. Change displayed weeks via menu View > Number of Weeks.

Actual Results:
Change fails. Number of weeks stay the same. Console shows:

WARNING: Trying to set pref calendar.weeks.inview to with the wrong type!: file e:/dev/comm-central/src/mozilla/modules/libpref/src/prefapi.cpp, line 722

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch2.setCharPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: setPref :: line 524"  data: no]

This fails in older 1.0pre builds too, therefore the regression range is somewhere between Sunbird 0.9 and 1.0pre.

Comment 1

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

In the property setter for 'weeksInView' in calendar-views.xml, you get for 'typeof(val)' 'string'.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 384419 [details] [diff] [review]
Patch v1

r=ssitter

Comment 3

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/19225b221840>

-> FIXED

Comment 4

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100305 Calendar/1.0b2pre

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".