499542 - View menu entries Rotate View and Workweek Days Only are always disabled

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090621 Calendar/1.0pre (BuildID: 20090621002041)

Steps to Reproduce:
1. Start Sunbird
2. Switch to Day View or Week View
3. Enable menu View > Rotate View
4. Enable menu View > Workweek Days Only

Actual Results:
Not possible. The menu entries are always disabled. Debug console shows:

An error occurred updating the calendar_toggle_orientation_command command
An error occurred updating the calendar_toggle_workdays_only_command command
An error occurred updating the calendar_show_unifinder_command command
An error occurred updating the calendar_mode_calendar command
An error occurred updating the calendar_mode_task command

Regression Range: Works in Sunbird 1.0pre (20090620031608)
                  Fails in Sunbird 1.0pre (20090621002041)

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We should look into this for the beta

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This takes care and also fixes bug 499537.

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 384371 [details] [diff] [review]
Fix - v1

r=ssitter

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4bd70de4cf76>

-> FIXED

Comment 6

[Damian Szczepanik]

verifying with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100305 Calendar/1.0b2pre

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".