499594 - Release updates tools (patcher, config bumps) need a brand option

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

In bug 498110 work toward SeaMonkey release automation (bug 493451), I came realize that we assume the capitalized brand name to be a first-letter-uppercased version of the lowercase app name. In the case of "seamonkey"->"SeaMonkey" that method doesn't work, so we need to make all tools that rely on that aware of a brand name options where we can pass this separately (and fall back to the previous behavior if it's omitted).

This affects patcher-config-bump.pl, update-verify-bump.pl and even patcher2.pl.

Comment 1

[Robert Kaiser]

Attachment: bump scripts patch, v1

This is the patch for the bump scripts against build/tools on hg, falling back to the previous behavior nicely.
One part if this patch is slightly unrelated but I hope I can sneak it in with this instead of doing an extra patch against patcher-config-bump.pl - we have different release notes URLs for SeaMonkey.

Comment 2

[Robert Kaiser]

Attachment: patcher patch, v1

Thankfully, the patcher patch is quite easy, as it's already abstracting getting this name with the GetApp() function.

Comment 3

[[e-mail] (:bhearsum)]

I did a mock release with this patch today and it went great. I'll do an actual review tomorrow.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 384316 [details] [diff] [review]
bump scripts patch, v1

This is fine. There's a bit of context bitrot, so please be careful when you land it.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 384318 [details] [diff] [review]
patcher patch, v1

Yeah, seems fine.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 384318 [details] [diff] [review]
patcher patch, v1

Checking in MozAUSConfig.pm;
/cvsroot/mozilla/tools/patcher/MozAUSConfig.pm,v  <--  MozAUSConfig.pm
new revision: 1.19; previous revision: 1.18
done

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 384316 [details] [diff] [review]
bump scripts patch, v1

changeset:   315:50e628530fff

Comment 8

[[e-mail] (:bhearsum)]

Attachment: cvs diff -u -r UPDATE_PACKAGING_R8 run from a fresh UPDATE_PACKAGING_R9 checkout

I created UPDATE_PACKAGING_R9 in the tools repository and CVS (by following the instructions here: https://bugzilla.mozilla.org/show_bug.cgi?id=420947#c17).

As expected, the only differences between R8 and R9 in CVS are the patch in this bug, some Bootstrap config files, and the tags in client.mk. I'm attaching a diff in case anyone wants to verify.

Comment 9

[Robert Kaiser]

Thanks for checking in, marking fixed as the patches seem to stick.