Closed
Bug 499611
Opened 15 years ago
Closed 15 years ago
Instrument nsLineList for trace-refcnt
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jruderman)
References
Details
Attachments
(1 file)
747 bytes,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
16 of 13631 leak when running crashtests. (Bug 499607 identifies one testcase that causes a leak.) Do these leaks have to be fixed before this instrumentation patch can be checked in?
Attachment #384341 -
Flags: review?(dbaron)
Comment on attachment 384341 [details] [diff] [review] patch r=dbaron (this assumes nobody ever calls the copy-constructor, which is probably safe in this case) It's probably a lot easier to land this after the leaks are fixed.
Attachment #384341 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•15 years ago
|
||
I ran this patch through try server (try rev 4cf1e54e389f), and it didn't identify any nsLineList leaks while running unit tests :) I'll land the patch on mozilla-central when it's greener.
Assignee | ||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ee5f3bce8681
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•