Closed
Bug 499730
Opened 15 years ago
Closed 15 years ago
Fix handling of beta/intl in update-check
Categories
(Camino Graveyard :: Product Site, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
Attachments
(1 file, 1 obsolete file)
2.58 KB,
patch
|
alqahira
:
review+
|
Details | Diff | Splinter Review |
The current script treats all Intl versions as betas; it's harmless since our betas are all non-intl, but it could bite us later. I need to tighten the regex and then do a bunch of testing.
Assignee | ||
Comment 1•15 years ago
|
||
I've tested this locally and it worked, but it wouldn't hurt to give it a sanity check as the test version of update-check ;)
Attachment #388167 -
Flags: review?(alqahira)
What is the specific test case for comment 0 that we want to prevent? 1.6.7Int checks for updates and receives an update to a hypothetical 2.0b3Int instead of 1.6.8Int?
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 388167 [details] [diff] [review] fix Yes (where the hypothetical 2.0b3Int doesn't have a min version, as our current series of 2.0 betas do). Except I'm an idiot. It's Int, not Intl, so this doesn't work. I'll do a new patch tomorrow morning.
Attachment #388167 -
Flags: review?(alqahira)
Assignee | ||
Comment 4•15 years ago
|
||
This will handle both Int and Intl, just in case anyone making the builds makes the same mistake ;)
Attachment #388167 -
Attachment is obsolete: true
Attachment #388215 -
Flags: review?(alqahira)
Attachment #388215 -
Attachment is patch: true
Attachment #388215 -
Attachment mime type: application/octet-stream → text/plain
Comment on attachment 388215 [details] [diff] [review] v2 This seems to work OK for me as update-check-test, including testing against a fake 2.0b3Int with no min version set. Of course, the last version seemed to work OK, too, so who knows what I'm not testing :P >+# Returns true if the given version is a release version (i.e., not an alpha, >+# beta, or nightly). >+sub version_is_release { >+ my ($version) = @_; >+ $version =~ s/\s*intl?$//i; >+ return $version !~ /(?:(?:a|b)\d*|pre)$/; >+} r=ardissone with a comment there about why we're checking for {int|intl}, so we don't perpetuate any confusion.
Attachment #388215 -
Flags: review?(alqahira) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Landed on CVS trunk with added comment.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Pushed live.
You need to log in
before you can comment on or make changes to this bug.
Description
•