499785 - SeaMonkey can't handle spaces in OpenURL, Firefox can

Status: ASSIGNED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Adrian Bunk]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1pre) Gecko/20090622 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1pre) Gecko/20090622 SeaMonkey/2.0b1pre

firefox and seamonkey already running.

$ firefox -remote 'OpenURL(http://www.google.com/asdf asdf)'
$ seamonkey -remote 'OpenURL(http://www.google.com/asdf asdf)'

Firefox opens "http://www.google.com/asdf asdf"
Seamonkey opens "http://www.google.com/asdf"

I have some memory that it was documented somewhere that spaces in OpenURL don't work, but considering that Firefox supports it it would be nice to get this functionality copied into Seamonkey.

Reproducible: Always

Comment 1

[Adrian Bunk]

This bug can hit you e.g. when doing Social Bookmarking from Liferea.

In practice, whatever Firefox supports is what gets used by applications.

Please check whether that's something that could easily be ported from Firefox for Seamonkey 2.0 .

Thanks in advance

Comment 2

[Robert Kaiser]

Neil, can you take a look at this? It _might_ be easy, depending on how URLs are handled there...

Comment 3

[[e-mail]]

The regexp we use currently allows "http://www.google.com/asdf new-tab" (or new-window) when it should require a comma.

Comment 4

[[e-mail]]

Attachment: Possible patch

[Bah, -remote doesn't work on initial startup. It really ought to just allow startup to continue as normal, but still open the remoted URL.]

Comment 5

[[e-mail]]

(In reply to comment #4)
> [Bah, -remote doesn't work on initial startup. It really ought to just allow
> startup to continue as normal, but still open the remoted URL.]
Conveniently it does work on Windows, if I launch the build I just patched...

Comment 6

[Adrian Bunk]

(In reply to comment #4)
> Created an attachment (id=401693) [details]
> Possible patch
> 
> [Bah, -remote doesn't work on initial startup. It really ought to just allow
> startup to continue as normal, but still open the remoted URL.]

That patch regresses heavily for me:

With this patch even
  seamonkey -remote 'OpenURL(http://www.google.com/asdf)'
(the normal non-space case) now opens an empty new window instead of the requested page in a new tab.

Comment 7

[[e-mail]]

Attachment: Try this

I accidentally omitted a ? :-(

Comment 8

[Adrian Bunk]

(In reply to comment #7)
> Created an attachment (id=401697) [details]
> Try this

Thanks, works for me.

Comment 9

[Adrian Bunk]

Can anyone review the patch, and apply it if it is considered OK?

Thanks in advance

Comment 10

[Philip Chee]

mcsmurf! Please check your review queue!

Comment 11

[Justin Wood (:Callek)]

Neil, can you check the patch for bitrot and make sure it still does as you want, I'll review for you. But we (sadly) cannot get this into 2.1 now.