SeaMonkey can't handle spaces in OpenURL, Firefox can

ASSIGNED

Status

SeaMonkey
Startup & Profiles
--
trivial
ASSIGNED
9 years ago
7 years ago

People

(Reporter: Adrian Bunk, Assigned: neil@parkwaycc.co.uk)

Tracking

unspecified
x86
Linux
Bug Flags:
wanted-seamonkey2.0 +

SeaMonkey Tracking Flags

(seamonkey2.1 wontfix)

Details

Attachments

(1 attachment, 1 obsolete attachment)

574 bytes, patch
neil@parkwaycc.co.uk
: review?
mcsmurf
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1pre) Gecko/20090622 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1pre) Gecko/20090622 SeaMonkey/2.0b1pre

firefox and seamonkey already running.

$ firefox -remote 'OpenURL(http://www.google.com/asdf asdf)'
$ seamonkey -remote 'OpenURL(http://www.google.com/asdf asdf)'

Firefox opens "http://www.google.com/asdf asdf"
Seamonkey opens "http://www.google.com/asdf"

I have some memory that it was documented somewhere that spaces in OpenURL don't work, but considering that Firefox supports it it would be nice to get this functionality copied into Seamonkey.

Reproducible: Always
(Reporter)

Comment 1

9 years ago
This bug can hit you e.g. when doing Social Bookmarking from Liferea.

In practice, whatever Firefox supports is what gets used by applications.

Please check whether that's something that could easily be ported from Firefox for Seamonkey 2.0 .

Thanks in advance
Flags: wanted-seamonkey2.0?

Comment 2

9 years ago
Neil, can you take a look at this? It _might_ be easy, depending on how URLs are handled there...
Summary: SEamonkey can't handle spaces in OpenURL, Firefox can → SeaMonkey can't handle spaces in OpenURL, Firefox can
(Assignee)

Comment 3

9 years ago
The regexp we use currently allows "http://www.google.com/asdf new-tab" (or new-window) when it should require a comma.
(Assignee)

Comment 4

9 years ago
Created attachment 401693 [details] [diff] [review]
Possible patch

[Bah, -remote doesn't work on initial startup. It really ought to just allow startup to continue as normal, but still open the remoted URL.]
Assignee: nobody → neil
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #401693 - Flags: review?(bugzilla)
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> [Bah, -remote doesn't work on initial startup. It really ought to just allow
> startup to continue as normal, but still open the remoted URL.]
Conveniently it does work on Windows, if I launch the build I just patched...
(Reporter)

Comment 6

9 years ago
(In reply to comment #4)
> Created an attachment (id=401693) [details]
> Possible patch
> 
> [Bah, -remote doesn't work on initial startup. It really ought to just allow
> startup to continue as normal, but still open the remoted URL.]

That patch regresses heavily for me:

With this patch even
  seamonkey -remote 'OpenURL(http://www.google.com/asdf)'
(the normal non-space case) now opens an empty new window instead of the requested page in a new tab.
(Assignee)

Comment 7

9 years ago
Created attachment 401697 [details] [diff] [review]
Try this

I accidentally omitted a ? :-(
Attachment #401693 - Attachment is obsolete: true
Attachment #401697 - Flags: review?(bugzilla)
Attachment #401693 - Flags: review?(bugzilla)
(Reporter)

Comment 8

9 years ago
(In reply to comment #7)
> Created an attachment (id=401697) [details]
> Try this

Thanks, works for me.

Updated

9 years ago
Flags: wanted-seamonkey2.0? → wanted-seamonkey2.0+

Updated

9 years ago
Severity: enhancement → trivial
(Reporter)

Comment 9

8 years ago
Can anyone review the patch, and apply it if it is considered OK?

Thanks in advance
Flags: wanted-seamonkey2.1?

Updated

8 years ago
Component: General → Startup & Profiles
QA Contact: general → profile-manager

Updated

8 years ago
status-seamonkey2.1: --- → wanted
Flags: wanted-seamonkey2.1?

Comment 10

8 years ago
mcsmurf! Please check your review queue!
Neil, can you check the patch for bitrot and make sure it still does as you want, I'll review for you. But we (sadly) cannot get this into 2.1 now.
status-seamonkey2.1: wanted → wontfix
You need to log in before you can comment on or make changes to this bug.