500001 - fix compiler warnings in c-sdk/ldap

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[timeless]

Attachment: changes

comm-central/directory/c-sdk/ldap/libraries/liblber/io.c
In function ‘ber_flush’:
401: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘ssize_t’

comm-central/directory/c-sdk/ldap/libraries/libldap/authzidctrl.c
73: warning: passing argument 3 of ‘nsldapi_build_control’ makes integer from pointer without a cast

comm-central/directory/c-sdk/ldap/libraries/libldap/memcache.c
In function ‘ldap_memcache_flush_results’:
510: warning: format ‘%x’ expects type ‘unsigned int’, but argument 4 has type ‘struct LDAPMemCache *’

comm-central/directory/c-sdk/ldap/libraries/libldap/pwpctrl.c
In function ‘ldap_create_passwordpolicy_control’:
67: warning: passing argument 3 of ‘nsldapi_build_control’ makes integer from pointer without a cast
In function ‘ldap_create_passwordpolicy_control_ext’:
107: warning: passing argument 3 of ‘nsldapi_build_control’ makes integer from pointer without a cast

comm-central/directory/c-sdk/ldap/libraries/libldap/result.c
In function ‘wait4msg’:
304: warning: format ‘%ld’ expects type ‘long int’, but argument 5 has type ‘__darwin_suseconds_t’

comm-central/directory/c-sdk/ldap/libraries/libldap/userstatusctrl.c
In function ‘ldap_create_userstatus_control’:
73: warning: passing argument 3 of ‘nsldapi_build_control’ makes integer from pointer without a cast
In function ‘ldap_parse_userstatus_control’:
104: warning: unused variable ‘len’

comm-central/directory/c-sdk/ldap/libraries/libldap/whoami.c
In function ‘ldap_parse_whoami’:
75: warning: unused variable ‘retdatap’
74: warning: unused variable ‘authzidp’

Comment 1

[Mark Smith [:mcs]]

Comment on attachment 384672 [details] [diff] [review]
changes

These changes look fine.  Thanks for taking time to clean up these warnings.

Comment 2

[Nikolay Shopik]

Doest this actually submitted into CVS or still waiting?

Comment 3

[Mark Banner (:standard8)]

Checking in ldap/libraries/liblber/io.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/liblber/io.c,v  <--  io.c
new revision: 5.10; previous revision: 5.9
done
Checking in ldap/libraries/libldap/authzidctrl.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/authzidctrl.c,v  <--  authzidctrl.c
new revision: 5.2; previous revision: 5.1
done
Checking in ldap/libraries/libldap/memcache.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/memcache.c,v  <--  memcache.c
new revision: 5.8; previous revision: 5.7
done
Checking in ldap/libraries/libldap/pwpctrl.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/pwpctrl.c,v  <--  pwpctrl.c
new revision: 5.4; previous revision: 5.3
done
Checking in ldap/libraries/libldap/result.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/result.c,v  <--  result.c
new revision: 5.10; previous revision: 5.9
done
Checking in ldap/libraries/libldap/userstatusctrl.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/userstatusctrl.c,v  <--  userstatusctrl.c
new revision: 5.2; previous revision: 5.1
done
Checking in ldap/libraries/libldap/whoami.c;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/whoami.c,v  <--  whoami.c
new revision: 5.2; previous revision: 5.1
done

This bug is now fixed, I'm looking at getting comm-central to pick it up in bug
520476.