500114 - MODIFICATION_FAILED Error after editing occurrence of repeating task in Task List

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Matthew Mecca [:mmecca]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090612 Lightning/1.0pre Shredder/3.0b3pre

MODIFICATION_FAILED Error after editing occurrence of repeating task in Task List

Reproducible: Always

Steps to Reproduce:
1.Create a new task. Set date and due date. Set as repeating daily.
2.Switch to Task View. Under "Show" select "Next Seven Days".
3.Click the check box on any occurrence to mark complete (Task List will not be updated).
4.Click the check box again (or attempt any other edit on any item in the Task List)

Actual Results:  
Error message with error code MODIFICATION_FAILED.
Console shows "Error code: 0x80004005. Description: generation too old for for modifyItem."
Task List is not updated.
Reloading calendar shows that task occurrence was successfully marked completed.

Expected Results:  
Task List is updated showing occurrence marked completed, without calendar reload required.

Also adding/deleting repeating tasks in date-bound list is not updating Task List properly.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: Proposed Patch

Comment 2

[Bas van den Bosch]

complete errors for local calendars: 
Warning: There has been an error reading data for calendar: Home.  However, this error is believed to be minor, so the program will attempt to continue. Error code: 0x80004005. Description: generation too old for for modifyItem
Error: An error occurred when writing to the calendar Home! Error code: MODIFICATION_FAILED. Description: 

Source File: file:///C:/Documents%20and%20Settings/bas/Application%20Data/Thunderbird/Profiles/5zn3aiz7.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Documents%20and%20Settings/bas/Application%20Data/Thunderbird/Profiles/5zn3aiz7.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js
Line: 976

for (local) ics:
Warning: There has been an error reading data for calendar: bas ics test. It has been placed in read-only mode, since changes to this calendar will likely result in data-loss.  You may change this setting by choosing 'Edit Calendar'. Error code: 0x80004005. Description: generation mismatch in modifyItem

Error: An error occurred when writing to the calendar bas ics test! Error code: MODIFICATION_FAILED. Description: 
Source File: file:///C:/Documents%20and%20Settings/bas/Application%20Data/Thunderbird/Profiles/5zn3aiz7.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///C:/Documents%20and%20Settings/bas/Application%20Data/Thunderbird/Profiles/5zn3aiz7.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js
Line: 976

So confirming and setting wanted 1.0 as you added a patch

Comment 3

[Stefan Sitter [:ssitter]]

Is this patch supposed to fix bug 350174? From a very quick look it seems so.

Comment 4

[Bas van den Bosch]

@ssitter: it looks like the viewing part of bug 350174 comment 12 is already incorporated in the task-view but not in the today-pane (follow STR in comment 0 to view this). If the fix works, we still need a fix for the list in the today-pane. 

@Matthew: Your fix doesn't clone recurring instances of tasks into seperate tasks, does it? I looks to me like it makes it possible to apply a modification/deletion of all instances of a recurring task?

Comment 5

[Matthew Mecca [:mmecca]]

@Stefan: This patch should allow editing of occurrences of repeating tasks where they are shown (currently only in date-bound task lists), but the issue of "how do we want to display infinitely recurring items in unbound lists" still exists, see Bug 350174 comment 9. I believe this will apply to the today-pane as well.

@Bas: No this should not clone occurrences into separate tasks, so modification/deletion should be possible on all instances or individual occurrences via the Edit/Delete Recurring Task dialog.

Comment 6

[Matthew Mecca [:mmecca]]

Bug should be fixed by proposed patch to bug 350174, marking this patch obsolete.

Comment 7

[Matthew Mecca [:mmecca]]

Fixed by Bug 350174