500128 - Long js files (longer than 65535 lines long ?) have incorrect line numbers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[John J. Barton]

Originally reported at Firebug
http://code.google.com/p/fbug/issues/detail?id=1900
 
The test case is 70000 lines of comments and a function that has an error at line 70003. The error is reported at line 4467.  This is just one symptom. Breakpoints etc don't work. User thinks the lines wrap. 

This problem is going to be suddenly very big. Both dojo and ExtJS have now gone over  60kloc and devs have discovered that loading one be JS file is much faster than 30 smaller files. 

The test code should appear at
http://getfirebug.com/tests/issues/1900 whenever the server thinks its time.

Comment 1

[Brendan Eich [:brendan]]

This is fixed in 3.5, by the patch for bug 490818.

/be

Comment 2

[John J. Barton]

My tests on 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090616 Firefox/3.5

Still gives line 4467 for its error message. The function that is created ('test') has a baseLineNumber of 1 and lineExtent of 4471.  The correct answer would be 70002 and 3 or so.

jjb

Comment 3

[John J. Barton]

Attachment: html to call for large js file

Comment 4

[John J. Barton]

Attachment: large js

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: testcase long.html.bz2

Comment 6

[Bob Clary [:bc] (inactive)]

This isn't fixed.

Comment 7

[Steve Roussey (:sroussey)]

Not fixed in Fx 3.5.2 and not fixed in Fx 3.6a1

Comment 8

[Ed]

Attachment: proposed fix

There's a whole bunch of casts to uint16 in jsscan.cpp and jsscan.h that probably need to be updated.  Can someone take a look at the attached patch?

Comment 9

[Brendan Eich [:brendan]]

Oh good grief! Ed, thanks for finding the bug. The patch can be simplified not to cast at all, though. The casts originally were to silence warnings and signal intent to chop to uint16, in the days of mythical <64Kline JS sources.

/be

Comment 10

[Brendan Eich [:brendan]]

Attachment: patch to commit

My fault, I'll get this revised version of Ed's patch, r=me, checked into the tracemonkey repo right away. Thanks again,

/be

Comment 11

[Brendan Eich [:brendan]]

Fixed in tm:

http://hg.mozilla.org/tracemonkey/rev/deb19a62f1f9

JJB, anyone: please nominate for branches as appropriate. Thanks,

/be

Comment 12

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/deb19a62f1f9

Comment 13

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cbc59703cc4d