500205 - L10n repack fails if ChatZilla or venkman are missing from build

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Robert Kaiser]

I did the first bunch of release automation tests with ChatZilla excluded as I didn't have a staging CVS and didn't want to tag any live repo. What I did find out with that was that we fail L10n repackaging when either ChatZilla or venkman are configured off.
This is not hard to fix, so I think we should just add that flexibility to our build system.

Comment 1

[Robert Kaiser]

Attachment: add ifdefs for the extensions

Here's the pretty easy patch to ifdef the relevant pieces to only be used if we haven't excluded the extensions.

Comment 2

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/4f619bab5b2e

Comment 3

[Vlado Valastiak [:wladow]]

This doesn't work well, ChatZilla's langpacks are missing from todays nightly builds. Plus sk tinderbox should be red due to missing strings in ChatZilla localization, but it turned green/orange today.

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> This doesn't work well, ChatZilla's langpacks are missing from todays nightly
> builds. Plus sk tinderbox should be red due to missing strings in ChatZilla
> localization, but it turned green/orange today.

Is this in comm-central or comm-1.9.1 nightlies? The former could very well have a configuration problem due to their hacky way of doing rebuilds, I'll need to look into that in this case.

Comment 5

[Vlado Valastiak [:wladow]]

Both c-c and c-1.9.1

Comment 6

[Robert Kaiser]

Attachment: oops

All I can say is: D'Oh!

I should have tested that not only the exclusion works but also the inclusion. MOZ_EXTENSIONS isn't even defined in the comm-central build system - which I should know, of course.
The only thing we can do reasonably is test if the directory exists before executing make on it, and this patch does that.
And this time I tested that it works for the more common case of actually _in_cluding things ;-)

Comment 7

[Robert Kaiser]

Attachment: test for the directories instead

Another d'Oh! I should actually attach the right one of my patches ;-)

Comment 8

[Robert Kaiser]

Pushed the new patch as http://hg.mozilla.org/comm-central/rev/b9dd4c1ffd4d - I hope this is really fixed now.