500208 - <select> element should update label when script changes selection

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Fix in bug 472426 does not handle updating the <select> label when script changes the selection either using select.selectedIndex or option.selected

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: JS Part v0.1

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: CPP Part v0.1

This use the pre-existent pref ui.use_native_popup_windows (camino) for overriding the open popup behavior on mousedown.

I've not find a Flag for saying MOBILE, just WINCE && HILDON but it looks like there is not effect on desktop?

The downside of this hack is if a developer use an html:select on the right panel this doesn't work.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This also resolve bug 500206.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien - We need a solution that can handle changing listbox <select> too. Not just combobox <select>

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Not sure of what you mean. 
http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsListControlFrame.cpp#1011

ToolkitHasNativeMenu() is called in list too.

It can be my fault, if you have my patch it I've forgot the <children /> tag.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot-1

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot-2

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot-3

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot-4

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Screenshot-5

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

OK, let's try moving this forward.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 385179 [details] [diff] [review]
Patch v0.2

Also remove:

selectListDisplay.format

from browser.dtd

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Js part v0.3

Remove the string from browser.dtd
Display for the drop-down button in combobox

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Js Part v0.4

Add [size=1] in css rules

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Is there more CSS you can remove from content.css now that much of the XBL
content has been removed? Things like ".select-label-box" and others?

Also, I talked to Boris about the C++ change. He is OK with it as along as we add "ui.use_native_popup_windows" to all.js - defaulted to false:

pref("ui.use_native_popup_windows", false);

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Js Part v0.5

Remove the unused CSS
Refactor bindings.xml and browser-ui.js

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Cpp part V0.2

Add the pref in all.js defaulted to false

Comment 18

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

After a few more testing I thought there is more stuff we can add to the SelectHelper, for example scroll to the first selected item, or bind some keys to easily navigate in it.

I'm not already sure of the way to do for the key (listening onchange events, doing our own, ...). So, should I try to put all theses features in this bug or wait and open a new one once this one have land?

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #18)
> So, should I try to put all theses features in this bug or
> wait and open a new one once this one have land?

New bug

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 385381 [details] [diff] [review]
Js Part v0.5

Waiting for the C++ part to clear tests on mozilla-central before landing

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

C++ part: http://hg.mozilla.org/mozilla-central/rev/13deae34bdb8
JS part: http://hg.mozilla.org/mobile-browser/rev/290bb7999608

Comment 22

[Markus Stange [:mstange]]

The C++ part doesn't prevent the creation of a native widget for the popup, does it? As far as I can tell, nsCSSFrameConstructor::InitializeSelectFrame still gets all the way to nsWindow::Create (via view->CreateWidget).

Comment 23

[Dão Gottwald [:dao]]

bugspam