500283 - Keyset in event-edit-dialog should be localizable

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Markus Adrario [:Taraman]]

At the moment the keyset for the hotkeys in the dialog are hardcoded in the .xul-file [1].

These should be made localizable

[1]:
http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.xul#218

Comment 1

[Markus Adrario [:Taraman]]

Attachment: Patch V1

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 423636 [details] [diff] [review]
Patch V1

I suggest to use .commandkey instead of .key and to align the names with the corresponding and existing entries. Example:

  <!ENTITY  event.menu.edit.undo.label      "Undo">
  <!ENTITY  event.menu.edit.undo.accesskey  "U">
+ <!ENTITY  event.menu.edit.undo.commandkey "Z">

Should the modifiers be localizable too? Looking in different source files it seems that sometimes they are hard-coded, sometimes localizable.

+ <!ENTITY  event.menu.edit.undo.modifiers  "accel">

Comment 3

[Markus Adrario [:Taraman]]

(In reply to comment #2)
> I suggest to use .commandkey instead of .key ...
that sounds more descriptive and therefore I agree


> ...and to align the names with the corresponding and existing entries. 
In this point I disagree.
The Keyset is defined in one block in the .xul and so it makes sense to me to have them in one block also in the .dtd.
Also the commandkeys are independant from the menu-items, even if they all call the same commands. So naming them after the menu-items is somewhat confusing to me.

> Should the modifiers be localizable too? Looking in different source files it
> seems that sometimes they are hard-coded, sometimes localizable.
> 
> + <!ENTITY  event.menu.edit.undo.modifiers  "accel">
I'm not sure here. This is a somewhat global question how we like it. IMHO it does not make sense to have the modifiers localizable, because they are the same keys worldwide - AFAIK - only the names are different.
But I think this should be decided for all the keys so we get that standardized.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 423636 [details] [diff] [review]
Patch V1

r=philipp, feel free to push any time.

Comment 5

[Markus Adrario [:Taraman]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/cde3da0606bd>

-> FIXED