Keyset in event-edit-dialog should be localizable

RESOLVED FIXED in 1.0b2

Status

--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Taraman, Assigned: Taraman)

Tracking

({l12y})

Trunk
1.0b2

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
At the moment the keyset for the hotkeys in the dialog are hardcoded in the .xul-file [1].

These should be made localizable

[1]:
http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.xul#218
Component: Calendar Views → Dialogs
QA Contact: views → dialogs
(Assignee)

Comment 1

9 years ago
Created attachment 423636 [details] [diff] [review]
Patch V1
Attachment #423636 - Flags: review?(philipp)
Status: NEW → ASSIGNED
Comment on attachment 423636 [details] [diff] [review]
Patch V1

I suggest to use .commandkey instead of .key and to align the names with the corresponding and existing entries. Example:

  <!ENTITY  event.menu.edit.undo.label      "Undo">
  <!ENTITY  event.menu.edit.undo.accesskey  "U">
+ <!ENTITY  event.menu.edit.undo.commandkey "Z">

Should the modifiers be localizable too? Looking in different source files it seems that sometimes they are hard-coded, sometimes localizable.

+ <!ENTITY  event.menu.edit.undo.modifiers  "accel">
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> I suggest to use .commandkey instead of .key ...
that sounds more descriptive and therefore I agree


> ...and to align the names with the corresponding and existing entries. 
In this point I disagree.
The Keyset is defined in one block in the .xul and so it makes sense to me to have them in one block also in the .dtd.
Also the commandkeys are independant from the menu-items, even if they all call the same commands. So naming them after the menu-items is somewhat confusing to me.

> Should the modifiers be localizable too? Looking in different source files it
> seems that sometimes they are hard-coded, sometimes localizable.
> 
> + <!ENTITY  event.menu.edit.undo.modifiers  "accel">
I'm not sure here. This is a somewhat global question how we like it. IMHO it does not make sense to have the modifiers localizable, because they are the same keys worldwide - AFAIK - only the names are different.
But I think this should be decided for all the keys so we get that standardized.
Comment on attachment 423636 [details] [diff] [review]
Patch V1

r=philipp, feel free to push any time.
Attachment #423636 - Flags: review?(philipp) → review+
(Assignee)

Comment 5

9 years ago
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/cde3da0606bd>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Target Milestone: 1.0 → 1.0b2
You need to log in before you can comment on or make changes to this bug.