500314 - Mozmill test for the security notification bar

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: testSecNotification.js

The following test goes to different http* url's of Verisign's website and verifies security notifications offered by the browser.


It references litmus testcases:

 *  Testcase ID #5920 - [security] Security notification

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 384995 [details]
testSecNotification.js

Wow, this test looks great! There are only some general rules which needs to be applied. The functionality is perfect.

>var testSecNotification = function() {
>		
>	// Close all tabs and open a blank page
>	UtilsAPI.closeAllTabs(controller);

Please use an indentation of 2 white spaces. Those should be spaces and no tabs. Please check your editor. There are tabs all over the place. Most times it is helpful to show the white spaces inside the editor.

>	controller.open('https://www.verisign.com/');
>	controller.waitForPageLoad(controller.tabs.activeTab);
>	var aboutVer = new elementslib.Link(controller.tabs.activeTab, "About VeriSign");	
>	UtilsAPI.delayedAssertNode(controller, aboutVer);

Please add an emtpy row between different actions. Further you don't need delayedAssertNode anymore for elements on a web page. This has changed because waitForPageLoad has been fixed. You can simply call controller.assertNode.

>	// Assign Elements needed for verification for Https sites

nit: Please be consistent in the use of die different case.

>	var cssSecInfo = controller.window.getComputedStyle(controller.window.document.getElementById("security-button"), "");	

Can you name it cssSecButton?

>	if (cssSecInfo.getPropertyValue('list-style-image') != 'url(chrome://browser/skin/Secure-statusbar.png)') {
>		throw 'Error: Security-Button image Http incorrectly assigned as: ' + cssSecInfo.getPropertyValue('list-style-image');

There is no need to place "Error: " as prefix. And please just throw a simple string like "Security button in status bar not visible". This applies to other throws too.

>	// Go to the https verisign redirect
>	controller.open('https://verisign.com');
>    UtilsAPI.delayedAssertNode(controller, aboutVer);

Please use waitForPageLoad here.

>	// Verify security functionality with https verisign redirect
>	var certLabel = new elementslib.ID(controller.tabs.activeTab, "cert_domain_link");
>
>	UtilsAPI.delayedAssertNode(controller, new elementslib.ID(controller.tabs.activeTab, "getMeOutOfHereButton"));
>	UtilsAPI.delayedAssertNode(controller, new elementslib.ID(controller.tabs.activeTab, "exceptionDialogButton"));

This will be normal assertNode checks.

Comment 2

[Aakash Desai [:aakashd]]

Attachment: testSecurity/testSecNotification.js

Ok, changes made per last review.

Comment 3

[Aakash Desai [:aakashd]]

Attachment: testSecurity/testSecNotification.js

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 385118 [details] [diff] [review]
testSecurity/testSecNotification.js

I had to fix the assertNode calls because they were wrong.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Checked-in: http://hg.mozilla.org/qa/mozmill-tests/rev/ecc143681b53

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In the last check for the cert error page the waitForPageLoad times out due to bug 503277. That's why this test takes much longer as expected.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I updated the test and changed the timeout of the waitForPageLoad function call to 1000. So we don't have to wait 30s anymore.

http://hg.mozilla.org/qa/mozmill-tests/rev/3832a30036ef

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.