500315 - Session restore not working when last tab was blank

Status: RESOLVED DUPLICATE of bug 495123

(Firefox :: Session Restore, defect)

Description

[Karel Jára]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/531.0 (KHTML, like Gecko) Chrome/3.0.190.1 Safari/531.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; cs; rv:1.9.1) Gecko/20090616 Firefox/3.5

The session restore doesn’t work properly if the last tab when you closed Firefox was an empty (about:blank) tab. It means every tab was closed before closing Firefox and the browser.tabs.closeWindowWithLastTab is set to false.

Reproducible: Always

Steps to Reproduce:
1. Close all tabs in last Firefox’s window (when browser.tabs.closeWindowWithLastTab is set to false) so there is the about:blank last tab
2. Close Firefox
3. Open Firefox
Actual Results:  
There is a session restore error telling you that there is a problem with restoring the last session, or the session is restored with the last but one tab which was open before closing all tabs and the Firefox window.

Expected Results:  
The session should be restored properly: One blank tab and history of tabs closed before.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Looks like a side effect of bug 490040. Perhaps we should check that pref when checking if a window is eligible for restoration at http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/nsSessionStore.js#649

Comment 2

[Simon Bünzli]

DUPE of bug 495123?