Closed Bug 500416 Opened 15 years ago Closed 15 years ago

going offline can hang imap connections

Categories

(MailNews Core :: Networking: IMAP, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

(Keywords: hang)

Attachments

(1 file)

Attached patch proposed fixSplinter Review
while looking into bug 475570, I hung going offline, w/o download. When trying to close down the open connections, SendData was returning an error, which made us call TellThreadToDie(), but that would end up being a recursive call, which would lead to contention with the UI thread. The simple fix is to avoid this re-entrant call.
Attachment #385115 - Flags: superreview?(bugzilla)
Attachment #385115 - Flags: review?(bugzilla)
Attachment #385115 - Flags: superreview?(bugzilla)
Attachment #385115 - Flags: superreview+
Attachment #385115 - Flags: review?(bugzilla)
Attachment #385115 - Flags: review+
Comment on attachment 385115 [details] [diff] [review]
proposed fix

nsImapProtocol won't get re-used after the thread has been shutdown, will it? (afaik it doesn't, but you probably know better).

r/sr=Standard8 if it doesn't get re-used.
No, the protocol object is definitely going away.

There's an outside chance this might fix some of the shutdown hangs, though I doubt it will.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: hang
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: