Modifying textnodes causes unnecessary reframing

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 385278 [details]
testcase (hangs on load)

The attached testcase is slower than necessary on trunk. It changes the contents of the text node in a block 100,000 times. It's 3x slower for white-space:normal than white-space:pre in my debug build. In the white-space:normal case we keep recreating the frame for the text because we've marked the text node with FRAMETREE_DEPENDS_ON_CHARS. We can fix this using the scheme in bug 495385 comment #57.
Created attachment 385291 [details] [diff] [review]
fix
Attachment #385291 - Flags: superreview?(bzbarsky)
Attachment #385291 - Flags: review?(bzbarsky)
Comment on attachment 385291 [details] [diff] [review]
fix

Makes sense.
Attachment #385291 - Flags: superreview?(bzbarsky)
Attachment #385291 - Flags: superreview+
Attachment #385291 - Flags: review?(bzbarsky)
Attachment #385291 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/8564af855794
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Depends on: 501878
You need to log in before you can comment on or make changes to this bug.