500596 - add an isExternC to variable and function declarations

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Daniel Rogers]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060308 Ubuntu/9.04 (jaunty) Firefox/3.0.11
Build Identifier: tip

after the patch isExternC will exist on all extern C function and variable declarations

Reproducible: Always

Comment 1

[Daniel Rogers]

Attachment: hg bundle

adds the property, and a test case

Comment 2

[(dormant account)]

(In reply to comment #1)
> Created an attachment (id=385323) [details]
> hg bundle
> 
> adds the property, and a test case

Can you post that as a plain patch? 

mercurial is complaining:
" an abort: 00changelog.i@3d3ec466400c: unknown parent"

Comment 3

[Jim Blandy :jimb]

If you're concerned about patches not being able to represent changes accurately, you should put the following in your ~/.hgrc file:

[diff]
git=true

That should get you git-style patches, which can record copies, renames, and the like.

Comment 4

[Daniel Rogers]

Attachment: patch for isExternC

Real actual patch instead of an hg bundle

Comment 5

[Daniel Rogers]

(In reply to comment #3)
> If you're concerned about patches not being able to represent changes
> accurately ...

Actually entirely driven by ignorance.  Never used hg before.

Comment 6

[Jim Blandy :jimb]

(In reply to comment #5)
> Actually entirely driven by ignorance.  Never used hg before.

:)  Okay.  git-style patches (as enabled by the .hgrc gunk I posted) are the way things are generally done at Mozilla.  People are used to reading them, Bugzilla has special support for them, etc. etc.  

Mercurial bundles are compact and carry more mercurial metadata, but they're not human-readable, and they're not "reparentable": they only apply to a specific parent change set, unlike patches, which can be applied to anything that's sufficiently textual similar.  Basically, bundles are what Mercurial ships across the network when you push and pull; Mercurial lets you treat them as files, too, for flexibility ("push" via thumb drives, say).

Comment 7

[(dormant account)]

Fixed the testcase to actually fail when things aren't working, also not committing the C testcase at this time as the testsuite doesn't support C yet.

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/a4711741cd98