Closed Bug 500617 Opened 11 years ago Closed 2 years ago

[HTML5] Remove always-zero offsets from HTML5 parser

Categories

(Core :: HTML: Parser, defect, P5)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: hsivonen, Assigned: alchen)

References

Details

Attachments

(2 files, 2 obsolete files)

The HTML5 parser has some legacy array offset arguments that are now always zero. Zap those.
Priority: -- → P5
Hi Henri,
is this what you want in this bug?
Flags: needinfo?(hsivonen)
(In reply to Alphan Chen [:alchen] from comment #1)
> is this what you want in this bug?

Yes. Thank you.
Flags: needinfo?(hsivonen)
Attachment #8913574 - Attachment description: Remove always-zero offsets from HTML5 parser. r?hsivonen → (html parser only) Remove always-zero offsets from HTML5 parser. r?hsivonen
Attachment #8913574 - Flags: review?(hsivonen)
Attachment #8913574 - Flags: review?(hsivonen) → review+
Comment on attachment 8915807 [details]
(gecko part) Remove always-zero offsets from HTML5 parser. r?hsivonen

Thank you.
Attachment #8915807 - Flags: review?(hsivonen) → review+
Assignee: nobody → alchen
Hi Henri,
could you push this patch for me?
Thanks.
Attachment #8913574 - Attachment is obsolete: true
Flags: needinfo?(hsivonen)
Attachment #8917303 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f79199fef1aa
Remove always-zero offsets from HTML5 parser. r=hsivonen
https://hg.mozilla.org/projects/htmlparser/rev/ce683a5d641dff44f10e7f198e534add6b48e0ae
Mozilla bug 500617 - Remove always-zero offsets from HTML5 parser, r=hsivonen
(In reply to Alphan Chen [:alchen] from comment #5)
> could you push this patch for me?

Pushed. Sorry about the delay.
Flags: needinfo?(hsivonen)
https://hg.mozilla.org/mozilla-central/rev/f79199fef1aa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Depends on: 1424548
Bug 500617 removed always-zero offsets in the generated parser code, but missed one in CPPONLY code in a parser Java file. I updated the Java code in bug 1424548.
You need to log in before you can comment on or make changes to this bug.