Closed
Bug 500617
Opened 15 years ago
Closed 7 years ago
[HTML5] Remove always-zero offsets from HTML5 parser
Categories
(Core :: DOM: HTML Parser, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: hsivonen, Assigned: alchen)
References
Details
Attachments
(2 files, 2 obsolete files)
|
9.51 KB,
patch
|
alchen
:
review+
|
Details | Diff | Splinter Review |
|
18.60 KB,
patch
|
alchen
:
review+
|
Details | Diff | Splinter Review |
The HTML5 parser has some legacy array offset arguments that are now always zero. Zap those.
|
Reporter | |
Updated•15 years ago
|
Priority: -- → P5
|
Assignee | |
Comment 1•7 years ago
|
||
Hi Henri, is this what you want in this bug?
Flags: needinfo?(hsivonen)
|
|
Reporter | |
Comment 2•7 years ago
|
||
(In reply to Alphan Chen [:alchen] from comment #1) > is this what you want in this bug? Yes. Thank you.
Flags: needinfo?(hsivonen)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8915807 -
Flags: review?(hsivonen)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8913574 -
Attachment description: Remove always-zero offsets from HTML5 parser. r?hsivonen → (html parser only) Remove always-zero offsets from HTML5 parser. r?hsivonen
Attachment #8913574 -
Flags: review?(hsivonen)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8913574 -
Flags: review?(hsivonen) → review+
|
|
Reporter | |
Comment 4•7 years ago
|
||
Comment on attachment 8915807 [details]
(gecko part) Remove always-zero offsets from HTML5 parser. r?hsivonen
Thank you.
Attachment #8915807 -
Flags: review?(hsivonen) → review+
|
||
Updated•7 years ago
|
Assignee: nobody → alchen
|
|
Assignee | |
Comment 5•7 years ago
|
||
Hi Henri, could you push this patch for me? Thanks.
Attachment #8913574 -
Attachment is obsolete: true
Flags: needinfo?(hsivonen)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d22002597c7f019db61824a85b7a9efdeb092a8&selectedJob=136133502
Attachment #8915807 -
Attachment is obsolete: true
Attachment #8917304 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8917303 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f79199fef1aa Remove always-zero offsets from HTML5 parser. r=hsivonen
|
|
Reporter | |
Comment 8•7 years ago
|
||
https://hg.mozilla.org/projects/htmlparser/rev/ce683a5d641dff44f10e7f198e534add6b48e0ae Mozilla bug 500617 - Remove always-zero offsets from HTML5 parser, r=hsivonen
|
|
Reporter | |
Comment 9•7 years ago
|
||
(In reply to Alphan Chen [:alchen] from comment #5) > could you push this patch for me? Pushed. Sorry about the delay.
Flags: needinfo?(hsivonen)
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f79199fef1aa
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 11•7 years ago
|
||
Bug 500617 removed always-zero offsets in the generated parser code, but missed one in CPPONLY code in a parser Java file. I updated the Java code in bug 1424548.
You need to log in
before you can comment on or make changes to this bug.
Description
•