500628 - <video> playing an audio ogg while sound disabled doesn't fire ended event

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: reftest - poster9.html

When bug 449156 'poster' landed on m-c, its reftest poster-9.html failed. This test has a video element which tries to play an ogg with audio only (no video stream). The test ends when 'ended' fires. The tinderboxen don't have audio hardware (or have it disabled) so presumably the test failed because the audio clock didn't advance and so it didn't fire the ended event. I removed the test, but we should figure out how to make it pass and re-add it.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1246002651.1246004927.9859.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1246006875.1246008562.17590.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1246008559.1246010447.5928.gz

Comment 1

[cajbir (:cajbir)]

If a device doesn't have sound hardware we sync off the system clock - the time should still advance. Without this no audio tests would work on the tinderbox and we have a couple of audio only tests (the space invaders sound and the shot).

Comment 2

[Matthew Gregan [:kinetik]]

We definitely do fire the ended event when playing Vorbis-only files with no audio backend.

The reftest references a file in content/media/test by the old path (content/media/video/test), and the poster and directory layout changes landed at the same time.  Are you sure that wasn't the problem?  I think it makes sense to keep a copy of the test file directly in the ogg-video reftest dir.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yes. I backed it out, and repushed with the path fixed, and it still failed.

Here's my push URL: http://hg.mozilla.org/mozilla-central/rev/16049cb4fe43

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: re-add poster9.html reftest.

The test now appears to work without sound enabled. I've pushed this to try, if it's green, we can land it.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #4)
> Created attachment 506632 [details] [diff] [review]
> Patch: re-add poster9.html reftest.
> 
> The test now appears to work without sound enabled. I've pushed this to try, if
> it's green, we can land it.

Hmm, the test failed on all platforms on TryServer... It passed locally for me, even with sound disabled... Have to look into this more sometime...

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Closing because the OggReader is being replaced and this is a vintage bug.