500630 - Cocoa plugins can draw outside their bounds

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

Nothing clips Cocoa plugins to their bounds. In fact, our test plugin draws outside its bounds (the stroke is centered on the border box edge). This isn't normally noticeable because we only ask the plugin to paint when we're painting its view, and its view clips to its bounds, but in some situations the plugin is asked to paint in another view and bugs show up. Try loading the attached testcase on trunk and scrolling around, a thick border is drawn and scrolling artifacts appear.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Not really testable with the frameworks we have now, as far as I know. The fix removes some unused code that is confusing, and then adds code to clip the plugin when we draw it. The FIXME was correct, we were failing to put aDirtyRect in the right coordinate system, but fortunately we were ignoring it in Paint() anyway.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/17f15b4efdab