500640 - Random failure in test_lastModified.js

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-unittest-everythingelse/build/xpcshell/tests/test_places/unit/test_lastModified.js | 1246017574985000 != 1246017574985000 - See following stack:
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-unittest-everythingelse\build\xpcshell\head.js :: do_throw :: line 181
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-unittest-everythingelse\build\xpcshell\head.js :: do_check_neq :: line 197
JS frame :: e:/builds/moz2_slave/mozilla-central-win32-unittest-everythingelse/build/xpcshell/tests/test_places/unit/test_lastModified.js :: run_test :: line 56

this is due to the fact the now() we set in js ends up being equal to the now we got in the backend, due to Virtual Machine timing issues.
The fix is quite easy, change now with now+1

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 2

[Jeff Muizelaar [:jrmuizel]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1246366891.1246374622.563.gz

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 386135 [details] [diff] [review]
patch v1.1

>+  bs.setItemLastModified(itemId, dateAdded + 1);

Might be good to check bs.getItemLastModified(itemId) === dateAdded + 1 here.

r=adw

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.2

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/0ccb9530d509