Closed
Bug 500640
Opened 12 years ago
Closed 12 years ago
Random failure in test_lastModified.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 2 obsolete files)
1.47 KB,
patch
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-unittest-everythingelse/build/xpcshell/tests/test_places/unit/test_lastModified.js | 1246017574985000 != 1246017574985000 - See following stack: JS frame :: e:\builds\moz2_slave\mozilla-central-win32-unittest-everythingelse\build\xpcshell\head.js :: do_throw :: line 181 JS frame :: e:\builds\moz2_slave\mozilla-central-win32-unittest-everythingelse\build\xpcshell\head.js :: do_check_neq :: line 197 JS frame :: e:/builds/moz2_slave/mozilla-central-win32-unittest-everythingelse/build/xpcshell/tests/test_places/unit/test_lastModified.js :: run_test :: line 56 this is due to the fact the now() we set in js ends up being equal to the now we got in the backend, due to Virtual Machine timing issues. The fix is quite easy, change now with now+1
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #385795 -
Flags: review?(adw)
Comment 2•12 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1246366891.1246374622.563.gz
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #385795 -
Attachment is obsolete: true
Attachment #386135 -
Flags: review?(adw)
Attachment #385795 -
Flags: review?(adw)
Comment 4•12 years ago
|
||
Comment on attachment 386135 [details] [diff] [review] patch v1.1 >+ bs.setItemLastModified(itemId, dateAdded + 1); Might be good to check bs.getItemLastModified(itemId) === dateAdded + 1 here. r=adw
Attachment #386135 -
Flags: review?(adw) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #386135 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0ccb9530d509
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Updated•9 years ago
|
Keywords: intermittent-failure
Updated•9 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•