500832 - commas are replaced by spaces when adding tags in bookmarks

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Tony Chung [:tchung]]

Adding commas to separate tags in bookmarks, will be replaced by spaces when saved.  Is this by design?

Repro: 
1) load any url and bookmark it
2) add multiple tags in the tags field, and separate them by commas (eg. "news, video, computers")
3) Click Done, and go back to bookmarks
4) Verify the tags are now displayed, minus the comma
5) also fill out the tags in awesomebar, and verify the bookmark entry is missing the commas

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I supposed we do the same thing in Fennec as in Firefox, when I'm in Firefox and click on the star, I've a dialog and a textbox for tags saying : 'Separate tags with commas'.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Exactly, we are just copying Firefox.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We were joining without the comma when showing the single bookmark editor. The bookmark list was fine.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/693b286c9bc0

Comment 5

[Carla Nadastean]

Retested with:
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111017 Firefox/10.0a1 Fennec/10.0a1
Device: Motorola Droid 2
OS: Android 2.3

Behavior on Fennec is the same as on Firefox: commas are not replaced with spaces in bookmark tags. Verifying bug.