500910 - GTK test plugin should take XShapes into account when computing clip region

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

When computing the plugin's effective clip region, the test plugin should consider any shape regions set on ancestor windows. We need this so that when we use shapes to clip plugins instead of ancestor widgets, tests still pass.

Comment 1

[Karl Tomlinson (:karlt)]

Comment on attachment 385562 [details] [diff] [review]
fix

-EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) $(XLDFLAGS) $(XLIBS)
+EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) $(XLDFLAGS) $(XLIBS) -lXext

$(XEXT_LIBS) is available for this.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/91a43fa9b0da

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I backed this out due to test failures.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1247207098.1247211633.9357.gz#err0

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

There was a critical missing gdk_intersect_region(region, windowRgn). I'm not sure how that happened, but the tests pass with this version of the patch.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/f7349b09a8ce