Closed
Bug 500944
Opened 16 years ago
Closed 15 years ago
window.getAttention undefined in a tab causes logging issues
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)
References
(Blocks 1 open bug)
Details
(Whiteboard: [cz-0.9.86])
Attachments
(1 file)
|
519 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
When ChatZilla is run in a tab, window.getAttention() doesn't exist (I see no reason it shouldn't but that's Mozilla/Toolkit for you). This is mostly OK as we usually don't do much after trying to call it, but if you log user views it causes all lines from the other party to be missing!
This should be fixed, as it's pretty bad, even in a non-supported situation.
|
Assignee | |
Comment 1•15 years ago
|
||
I made this global because it's easier, and so we can make it work in a tab later if we wanted to.
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #394747 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•15 years ago
|
Attachment #394747 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 394747 [details] [diff] [review]
Make getAttention no-op if not found
r=me
|
|
Assignee | |
Comment 3•15 years ago
|
||
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.86]
You need to log in
before you can comment on or make changes to this bug.
Description
•