Closed Bug 500971 Opened 11 years ago Closed 11 years ago

Remove obsolete tabs-closebutton binding

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dao, Assigned: dao)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch patchSplinter Review
SeaMonkey uses closebutton="true" on a tabs element, but with a custom binding like Firefox. closebutton="true" seems to be a leftover.

DOMi uses closebutton="true" on a splitter element. It doesn't seem to do anything.
Attachment #385618 - Flags: review?(enndeakin)
Attachment #385618 - Flags: review?(enndeakin) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/22ed91cb3441
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Keywords: dev-doc-needed
This isn't really interesting for theme authors, but XUL developers.
Why is it interesting for XUL developers? It seems like a theme issue to me.
This is about closebutton="true" in <tabs closebutton="true"/>. It's not supported anymore.
I'm still unclear on why this is interesting to XUL developers. Sorry...
I think it might be interesting to the ones who read https://developer.mozilla.org/en/XUL/tabs#a-closebutton, and put closebutton="true" in their tabs element, and then wonder where the closebutton that devmo promised them has gotten to.
Ah! See, the problem I had is I wasn't connecting the XBL to the element in my head for some reason. This is now fixed.

https://developer.mozilla.org/en/XUL/Attribute/closebutton
You need to log in before you can comment on or make changes to this bug.