500971 - Remove obsolete tabs-closebutton binding

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

SeaMonkey uses closebutton="true" on a tabs element, but with a custom binding like Firefox. closebutton="true" seems to be a leftover.

DOMi uses closebutton="true" on a splitter element. It doesn't seem to do anything.

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/22ed91cb3441

Comment 2

[Eric Shepherd [:sheppy]]

See https://developer.mozilla.org/en/Updating_themes_for_Firefox_3.6

Comment 3

[Dão Gottwald [:dao]]

This isn't really interesting for theme authors, but XUL developers.

Comment 4

[Eric Shepherd [:sheppy]]

Why is it interesting for XUL developers? It seems like a theme issue to me.

Comment 5

[Dão Gottwald [:dao]]

This is about closebutton="true" in <tabs closebutton="true"/>. It's not supported anymore.

Comment 6

[Eric Shepherd [:sheppy]]

I'm still unclear on why this is interesting to XUL developers. Sorry...

Comment 7

[Phil Ringnalda (:philor)]

I think it might be interesting to the ones who read https://developer.mozilla.org/en/XUL/tabs#a-closebutton, and put closebutton="true" in their tabs element, and then wonder where the closebutton that devmo promised them has gotten to.

Comment 8

[Eric Shepherd [:sheppy]]

Ah! See, the problem I had is I wasn't connecting the XBL to the element in my head for some reason. This is now fixed.

https://developer.mozilla.org/en/XUL/Attribute/closebutton