Remove obsolete tabs-closebutton binding

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.2a1
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

2.55 KB, patch
Neil Deakin (not available until Aug 9)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 385618 [details] [diff] [review]
patch

SeaMonkey uses closebutton="true" on a tabs element, but with a custom binding like Firefox. closebutton="true" seems to be a leftover.

DOMi uses closebutton="true" on a splitter element. It doesn't seem to do anything.
Attachment #385618 - Flags: review?(enndeakin)
Attachment #385618 - Flags: review?(enndeakin) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 1

8 years ago
http://hg.mozilla.org/mozilla-central/rev/22ed91cb3441
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Updated

8 years ago
Keywords: dev-doc-needed
See https://developer.mozilla.org/en/Updating_themes_for_Firefox_3.6
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 3

8 years ago
This isn't really interesting for theme authors, but XUL developers.
Keywords: dev-doc-complete → dev-doc-needed
Why is it interesting for XUL developers? It seems like a theme issue to me.
(Assignee)

Comment 5

8 years ago
This is about closebutton="true" in <tabs closebutton="true"/>. It's not supported anymore.
I'm still unclear on why this is interesting to XUL developers. Sorry...
I think it might be interesting to the ones who read https://developer.mozilla.org/en/XUL/tabs#a-closebutton, and put closebutton="true" in their tabs element, and then wonder where the closebutton that devmo promised them has gotten to.
Ah! See, the problem I had is I wasn't connecting the XBL to the element in my head for some reason. This is now fixed.

https://developer.mozilla.org/en/XUL/Attribute/closebutton
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.